Overview page: OverflowError when cinder limits are negative

Bug #1386687 reported by Julie Pichon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Julie Pichon
Icehouse
Fix Released
Medium
Julie Pichon
Juno
Fix Released
Medium
Julie Pichon

Bug Description

This is the Cinder twin to bug 1370869 which was resolved for Nova. For some yet-to-be-fully-debugged reasons, after deleting multiple instances the quota_usages table for Cinder ended up with negative values for several of the "in use" limits, causing the Overview Page to fail with an error 500:

OverflowError at /project/
cannot convert float infinity to integer

Even if this is (probably?) a rare occurrence, it would make sense to also add guards for the cinder limits and make the overview page more resilient.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/131436

Changed in horizon:
status: New → In Progress
Changed in horizon:
milestone: none → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/131436
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=53c7dc022ed4e0d5d60fb344b3e8c94e3dfb7d43
Submitter: Jenkins
Branch: master

commit 53c7dc022ed4e0d5d60fb344b3e8c94e3dfb7d43
Author: Julie Pichon <email address hidden>
Date: Tue Oct 28 13:02:15 2014 +0000

    Handle negative values in total*Used for Cinder absolute limits

    In some cases negative values can be returned for resources currently
    in use. When this occurs, the project overview page fails with an
    error 500 due to an OverflowError, "cannot convert float infinity to
    integer". Handle this case more gracefully.

    Change-Id: Id1ad16eafdde906dc74bfafc7f72ea8d3bdcdc8f
    Closes-Bug: #1386687

Changed in horizon:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/131721

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/132258

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/juno)

Reviewed: https://review.openstack.org/131721
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=146a72215c40e8697699ca2eaa165de5db135d14
Submitter: Jenkins
Branch: stable/juno

commit 146a72215c40e8697699ca2eaa165de5db135d14
Author: Julie Pichon <email address hidden>
Date: Tue Oct 28 13:02:15 2014 +0000

    Handle negative values in total*Used for Cinder absolute limits

    In some cases negative values can be returned for resources currently
    in use. When this occurs, the project overview page fails with an
    error 500 due to an OverflowError, "cannot convert float infinity to
    integer". Handle this case more gracefully.

    Change-Id: Id1ad16eafdde906dc74bfafc7f72ea8d3bdcdc8f
    Closes-Bug: #1386687
    (cherry picked from commit 53c7dc022ed4e0d5d60fb344b3e8c94e3dfb7d43)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/icehouse)

Reviewed: https://review.openstack.org/132258
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=7dd9ca6bb0131514fc325a03ede44d991b11e784
Submitter: Jenkins
Branch: stable/icehouse

commit 7dd9ca6bb0131514fc325a03ede44d991b11e784
Author: Julie Pichon <email address hidden>
Date: Tue Oct 28 13:02:15 2014 +0000

    Handle negative values in total*Used for Cinder absolute limits

    In some cases negative values can be returned for resources currently
    in use. When this occurs, the project overview page fails with an
    error 500 due to an OverflowError, "cannot convert float infinity to
    integer". Handle this case more gracefully.

    Change-Id: Id1ad16eafdde906dc74bfafc7f72ea8d3bdcdc8f
    Closes-Bug: #1386687
    (cherry picked from commit 53c7dc022ed4e0d5d60fb344b3e8c94e3dfb7d43)

Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.