Eye icon on field is misplaced if previous field has validation message

Bug #1386126 reported by Timur Sufiev
20
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Timur Sufiev
Juno
Fix Released
Undecided
Unassigned

Bug Description

You can see it on the Identity -> Users -> Create User form. Encountered on both master branch and juno. The same misplacement also occurs with the new awesome-font icons which are to replace current glyphicons.

Revision history for this message
Timur Sufiev (tsufiev-x) wrote :
Revision history for this message
Timur Sufiev (tsufiev-x) wrote :
tags: added: ux
Timur Sufiev (tsufiev-x)
Changed in horizon:
assignee: nobody → Timur Sufiev (tsufiev-x)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/131135

Changed in horizon:
status: New → In Progress
Timur Sufiev (tsufiev-x)
Changed in horizon:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/131135
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6ffebb6d200a071774048e792752cd201a5c6d0d
Submitter: Jenkins
Branch: master

commit 6ffebb6d200a071774048e792752cd201a5c6d0d
Author: Timur Sufiev <email address hidden>
Date: Mon Oct 27 15:37:11 2014 +0300

    Return eye-icon to its place when validation message is shown

    Making eye-icon properly positioned relies on its parent having
    'has-feedback' class - which makes the parent to obey 'position:
    relative' and thus eye-icon with its 'position: absolute' is properly
    positioned within it.

    Change-Id: I69ce13e1e3fc9674c4f25e7d04d79a3f550014a6
    Closes-Bug: #1386126

Changed in horizon:
status: In Progress → Fix Committed
Timur Sufiev (tsufiev-x)
Changed in horizon:
milestone: none → kilo-1
tags: added: juno-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/135562

Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/juno)

Reviewed: https://review.openstack.org/135562
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2cd943510a0b181fb79644390cdf8dc1ac95c571
Submitter: Jenkins
Branch: stable/juno

commit 2cd943510a0b181fb79644390cdf8dc1ac95c571
Author: Timur Sufiev <email address hidden>
Date: Mon Oct 27 15:37:11 2014 +0300

    Return eye-icon to its place when validation message is shown

    Making eye-icon properly positioned relies on its parent having
    'has-feedback' class - which makes the parent to obey 'position:
    relative' and thus eye-icon with its 'position: absolute' is properly
    positioned within it.

    Change-Id: I69ce13e1e3fc9674c4f25e7d04d79a3f550014a6
    Closes-Bug: #1386126
    (cherry picked from commit 6ffebb6d200a071774048e792752cd201a5c6d0d)

tags: added: in-stable-juno
Chuck Short (zulcss)
Changed in horizon:
status: Fix Released → Fix Committed
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.