API calls in openstack_dashboard.usage.quotas should be wrapped with try/except

[Akihiro Motoki]

API calls in openstack_dashboard.usage.quotas should be wrapped with try/except.

[Julie Pichon (jpichon)]

I think this is somewhat of a duplicate of bug 1249330 (which has a patch up for review)?

[Akihiro Motoki (amotoki)]

This is raised in a review https://review.openstack.org/#/c/129689/ which reduces the complexity of the code.

I was not aware of bug 1249330. Two bugs are similar but I think they are different.
bug 1249330 reports if retrieving quotas from Neutron fails quotas from other projects also fail,
but this bug reports errors from nova/cinder API calls are not caught.
The fix might be done in a single patch.

[Prabhjyot Singh Sodhi (psd0)]

As a newbie to open source I would love to try a stab at this bug.
Are you still working on this Martin?

[Sean Workman (sean-workman-14)]

I'd like to work on this task, has it already been completed?

[Andrew Lenards (lenards)]

I was just reviewing the source in question (openstack_dashboard/usage/quotas.py), and wrapping all the calls might harm the readability. Is there any chance an object proxy approach could be used to wrap {base, cinder, network, neturon, nova}? Similar, sort of, to decorating, but would allow you to intercept the calls and wrap them w/ the desired try/except.

I would imagine the concerns for such an approach would be:
- added overhead to the function calls
- adding new dependency (something like wrapt [0], perhaps)

[0] http://wrapt.readthedocs.io/en/latest/wrappers.html#object-proxy

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 19.1.0 release.

[Vishal Manchanda (vishalmanchanda)]

It is fixed by https://review.opendev.org/c/openstack/horizon/+/765144.