[data_processing] Droping dots in names of job binary downloads

Bug #1379455 reported by Chad Roberts
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Chad Roberts

Bug Description

Environment:

Devstack with Neutron.

How to reproduce:

1. Go to "Data processing" tab in OpenStack dashboard.
2. Go to "Job Binaries" tab.
3. Create a job binary. The name of the job binary should have points. For example, the job binary can be named "some.job.binary.jar".
4. Click on the created job binary.
5. Click the link to download the job binary.

Expected result:

The job binary can be successfully downloaded and has name "some.job.binary.jar".

Observed result:

The job binary can be successfully downloaded and has name "somejobbinaryjar".

Revision history for this message
Chad Roberts (croberts) wrote :

Original bug against Sahara was https://bugs.launchpad.net/sahara/+bug/1377948
I have made it a horizon bug and will squash it.

Changed in horizon:
assignee: nobody → Chad Roberts (croberts)
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/127320

Changed in horizon:
status: Confirmed → In Progress
David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Medium
David Lyle (david-lyle)
Changed in horizon:
milestone: none → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/127320
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=99656ece289b83263be3e1d639774a535bcef0c4
Submitter: Jenkins
Branch: master

commit 99656ece289b83263be3e1d639774a535bcef0c4
Author: Chad Roberts <email address hidden>
Date: Thu Oct 9 15:23:15 2014 -0400

    No longer stripping dots from downloaded filenames

    Previously, the filename (which comes from our database
    that validates the filenames at store-time) was
    being passed through defaultfilters.slugify and that
    was removing dots from the filenames, which was
    undesirable. Also added a unit test for this.

    Change-Id: I4fccf2c3e065be1c1ae3826ab5d4bded359db251
    Closes-Bug: #1379455

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.