horizon.d3piechart.js is failing jshint

Bug #1378766 reported by John Davidge
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
John Davidge

Bug Description

The current master of horizon.d3piechart.js is causing jshint to fail with the following error:

horizon/static/horizon/js/horizon.d3piechart.js: line 240, col 13, It's not necessary to initialize 'item' to 'undefined'.

Changed in horizon:
assignee: nobody → John Davidge (john-davidge)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/126876

Changed in horizon:
status: New → In Progress
Doug Fish (drfish)
Changed in horizon:
status: In Progress → Triaged
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/126876
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=3246569e7c2ae35829026c6ca6fe2b9568d4841e
Submitter: Jenkins
Branch: master

commit 3246569e7c2ae35829026c6ca6fe2b9568d4841e
Author: John Davidge <email address hidden>
Date: Wed Oct 8 04:19:27 2014 -0700

    Fix jshint failure in horizon.d3piechart.js

    The var "item" on line 240 was explicitly being set to "undefined",
    which is unnecessary.

    Change-Id: Ia4cb8f868a4b201e578157a8ad5c5e552ab6ac8a
    Closes-bug: 1378766

Changed in horizon:
status: Triaged → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → kilo-1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.