We've had a number of review problems/escaped bugs related to the handling of the environment_version in run_tests.sh.
The problem is that its an integer and it is supposed to increase sequentially. If there are multiple environment related patches out for review in parallel only the first one will update the environment_version. The others will have their environment_version successfully merge unless the developer or a reviewer noticed.
I plan to fix this by making the environment_version a string. It takes only a trivial change to the script to make this happen. Then the environment version can be the gerrit change number, possibly suffixed with a "/2" or "/3" if there are multiple review patches. This way the environment_versions will not secretly resolve and patches can reliably modify the environment_version.
Fix proposed to branch: master /review. openstack. org/125513
Review: https:/