OpenStack Dashboard (Horizon)

jshint error: == null in horizon.modals.js

Bug #1375401 reported by Doug Fish
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Doug Fish
OpenStack Dashboard (Horizon) 2014.2 "juno"

Bug Description

gate-horizon-jshint fails with

horizon/static/horizon/js/horizon.modals.js: line 236, col 29, Use '===' to compare with 'null'.

Doug Fish (drfish)
Changed in horizon:
assignee: nobody → Doug Fish (drfish)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/124829

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/124829
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=11403eca06037575cc66b2564375910f8b26ba76
Submitter: Jenkins
Branch: master

commit 11403eca06037575cc66b2564375910f8b26ba76
Author: Doug Fish <email address hidden>
Date: Mon Sep 29 13:29:42 2014 -0500

    Use identity operator in horizon.modals.js

    jshint logs usage of the equality operator as an error.

    Change-Id: Ia5478981f6ce87e77c65bcc569ae542eeeff099f
    Closes-Bug: #1375401

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
importance: Undecided → Medium
milestone: none → juno-rc1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.