submitted dates resets when switch to a different page

Bug #1373651 reported by Gloria Gu
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Justin Pomeroy

Bug Description

The submitted "from or to date" doesn't seem to be honored when switch to different language.

How to reproduce:

From Admin -> Overview

change the From or To date by picking up the different date, for example, today is 9/24/2014
The original From is 9/1/2014
The original To is 9/24/2014

Change From to 9/4/2014
Change To to 9/20/2014

click Submit

Make sure it is saved.

Now click other tab , for example Admin -> volumes

Go back to Admin -> Overview, you will notice that the saved From date 9/4/2014 is changed to 9/1/2014, the saved To date 9/20/2014 is changed to 9/24/2014.

Same issue in Project -> Overview as well.

Expected:

The saved From and To dates should not get changed when switch to a different page at least for the session.

Revision history for this message
Justin Pomeroy (jpomero) wrote :

I'm not seeing the dates being persisted at all, even when just switching to a different page. For example, set the From date to 9/4/2014 and submit. Then switch to another page such as Images, and switch back to Overview. The From date is reset. So this might not be related to the language.

Revision history for this message
Gloria Gu (gloria-gu) wrote :

Justin, you are right. the query string after click submit: http://myhost:8888/admin/?start=2014-09-15&end=2014-09-25, if move to different page, the query string lost, that might the reason. But I think at least the query date should be persistent at least for the session. Otherwise, it is really annoying.

summary: - saved dates resets when switch to a different language
+ saved dates resets when switch to a different page
description: updated
Gloria Gu (gloria-gu)
summary: - saved dates resets when switch to a different page
+ submitted dates resets when switch to a different page
description: updated
Revision history for this message
Justin Pomeroy (jpomero) wrote :

I agree Gloria. The dates should probably be persisted in the session.

Changed in horizon:
status: New → Confirmed
assignee: nobody → Justin Pomeroy (jpomero)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/124194

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/124194
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b388aaacb33fc607ee164853e3af262ede9f9745
Submitter: Jenkins
Branch: master

commit b388aaacb33fc607ee164853e3af262ede9f9745
Author: Justin Pomeroy <email address hidden>
Date: Thu Sep 25 15:13:36 2014 -0500

    Persist usage start and end dates in the session

    This patch adds the usage start and end dates to the user's session
    so they are saved while navigating between pages.

    Closes-Bug: #1373651
    Change-Id: I3046b5533eb96f85fb2f90e63b3ff84360ad14c4

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → juno-rc1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.