Disable the "Gateway IP" field when "Disable gateway" is checked

[Matthias Runge]

Does unchecking the Create Subnet checkbox mean that none of the information on this step is now required?

We are still required to enter Gateway IPs in the proper format even though unchecking that box should make that unnecessary (same for when the "Disable Gateway" box is checked.

[Sam Betts (sambetts)]

This review addresses this issue already -> https://review.openstack.org/#/c/123123/

[Gary W. Smith (gary-w-smith)]

This is the Create Network action on Network > Networks. I cannot reproduce this on master -- by unselecting Create Subnet on the second page of the wizard, I can proceed to the next wizard page and successfully create the network without entereing a gateway IP or network address.

Marking as incomplete. If you are able to reproduce this, please update the status and provide additional details on how to reproduce it. Thanks.

[Julie Pichon (jpichon)]

I think the idea here is to grey out/disable the fields when unchecking the box, so that it's clear to the user they are no longer required field. It sounds like Sam's patch in comment #1 addresses it though. Maybe the description for this bug should be changed to address this only for the gateway field (disable the field if the "Disable Gateway" checkbox is checked).

[Bradley Jones (bradjones)]

This sounds like a duplicate of this bug https://bugs.launchpad.net/horizon/+bug/1372313 which I have already submitted a patch for

[Justin Pomeroy (jpomero)]

If you check the "Disable Gateway" box you still need to enter a valid Gateway IP (or none) to move forward. If this box is checked and the field is hidden then the form should not care if the field is not valid. This issue doesn't seem to be fixed by either of the linked reviews above or this one either: https://review.openstack.org/211907. I hope this bug can be used to fix this.