Image Create/Edit Description field cannot contain newlines

[Nicolas Simonds]

With the Glance v1 API, Horizon does no input sanitization on the Image Description field, so newlines in the Description will be sent along verbatim, breaking the session.

A simple test case to reproduce:

1. Stand up a Devstack, login to Horizon, and go to the Project » Images page
2. Edit an image
3. Set the description to "foo\n\nbar" (i.e., "foo", two newlines, then "bar")
4. Set the name to "foo bar"

Expected behaviour:

The name of the image changes to "foo bar", and the description (on the Detail page) changes to "foo\n\nbar"

Actual behaviour:

The name is unchanged, and the description is set to "foo" The glance-api session on Devstack will also report an HTTP 400 error.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/122257

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/122257
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=363ccf7b39bb14624e60ee1aa1f08f4e3f5f0642
Submitter: Jenkins
Branch: master

commit 363ccf7b39bb14624e60ee1aa1f08f4e3f5f0642
Author: Nicolas Simonds <email address hidden>
Date: Wed Sep 17 14:49:08 2014 -0700

    Make Image Description an input field instead of a textarea

    The glanceclient passes the value of the "Description" field as
    HTTP headers to the API, completely unmodified. If there are
    newlines in the content, it corrupts the headers and creates havoc.

    Encoding/decoding the results is not viable, since arbitrary (and
    not necessarily controlled by anyone) clients can retrieve the data. So as
    a dodge, use a normal <input> field for Description instead of
    <textarea> field, as newlines are not permitted in the former.

    Closes-Bug: 1370732
    Change-Id: I0231eaa693e7f36699fda6e011db8c976b639411

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/165067

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/165100

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/165067
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=04d07dab7fe15cf1b773326c662018ea9fa8ef75
Submitter: Jenkins
Branch: stable/juno

commit 04d07dab7fe15cf1b773326c662018ea9fa8ef75
Author: Nicolas Simonds <email address hidden>
Date: Wed Sep 17 14:49:08 2014 -0700

    Make Image Description an input field instead of a textarea

    The glanceclient passes the value of the "Description" field as
    HTTP headers to the API, completely unmodified. If there are
    newlines in the content, it corrupts the headers and creates havoc.

    Encoding/decoding the results is not viable, since arbitrary (and
    not necessarily controlled by anyone) clients can retrieve the data. So as
    a dodge, use a normal <input> field for Description instead of
    <textarea> field, as newlines are not permitted in the former.

    Closes-Bug: 1370732
    Change-Id: I0231eaa693e7f36699fda6e011db8c976b639411
    (cherry picked from commit 363ccf7b39bb14624e60ee1aa1f08f4e3f5f0642)

[OpenStack Infra (hudson-openstack)]

Change abandoned by Jeremy Stanley (<email address hidden>) on branch: stable/icehouse
Review: https://review.openstack.org/165100
Reason: This branch has reached end of life and is being deleted.