Selecting an Image Name on the Launch Instance dialog resets Device size to 1GB

[Dafna Ron]

1. launch an instance and select "boot from image (create new volume)"
2. in 'Device size (GB):' write 10GB
3. save without selecting an image

results:

when we are redirected back to the launch instance box with error: "You must select an image." and select an image, the volume size changes to 1GB.

expected results:
1. size should not change
2. if we have to change size, than size should be deleted completely once we select a new image.

[Dafna Ron (dron-3)]

This might be related to iptables started by the system at some point.
However, if it is I think further info (trace print on permission) would be good.

[Liyingjun (liyingjun)]

There is no such problem for the upstream horizon, did you try this with upstream?

[Dafna Ron (dron-3)]

I have not but I will be installing in for test day tomorrow so will check and report in red hat if this is only in red hat.

[Gary W. Smith (gary-w-smith)]

+1 good catch

Just to be clear, the problem really is independent of the Launch / redirect step. The basic problem is that whenever you select an Image in the Image Name pulldown, it resets the Device size to 1 GB, overwriting anything you may have entered already.

[John Davidge (john-davidge)]

This behaviour is caused by the following patch: https://review.openstack.org/#/c/114292/

The problem identified here appears to be that if the user manually changes the Device Size value this isn't taken into account when the checks are made to decide whether the field needs to be updated on changing the image/flavor.

I propose a change that checks if a user has manually updated the Device Size, and if so will not override the user-entered value unless it is too small for the selected image/flavor.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/124750

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/124750
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=59af5f5c5a1da71103103e86463dcfb1d0e9e913
Submitter: Jenkins
Branch: master

commit 59af5f5c5a1da71103103e86463dcfb1d0e9e913
Author: John Davidge <email address hidden>
Date: Mon Sep 29 06:54:18 2014 -0700

    Do not override user-defined Device Size

    This change introduces a flag which identifies whether or not the
    user has manually set the Device Size field when launching an
    instance with a new volume. If the user has made a change then the
    value will not be overridden by the logic that sets the Device Size
    based on the selected image/flavor unless the user-defined value is
    too small.

    Change-Id: I1f02fd386a9b6836fb95433d9cb819af4f267d6c
    Closes-bug: 1370080