TypeError when accessing horizon_main_nav element

Bug #1368673 reported by Matthias Runge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Sam Betts

Bug Description

Our customized UI uses horizon_main_nav templatetag rather than horizon_nav. It's quite useful, if you just want to get main navigation items.

Sadly, since last panel chang, this is broken, failing on TypeError.

Tags: horizon-core
Sam Betts (sambetts)
Changed in horizon:
assignee: nobody → Sam Betts (sambetts)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/121052

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/121052
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=fa94e79eca609d9fade8624c40f3a959ae3e5bd4
Submitter: Jenkins
Branch: master

commit fa94e79eca609d9fade8624c40f3a959ae3e5bd4
Author: Sam Betts <email address hidden>
Date: Fri Sep 12 12:19:54 2014 +0100

    Corrected dash.can_access call to take context

    horizon_main_nav makes a call to dash.can_access which should take
    context but was being passed the request, this patch corrects that.
    Unit test added to prevent regression, and fix added to RbacHorizonTests
    to clean up changes to Cats and Dogs test dashboards, as it was
    affecting any test that followed.

    Change-Id: I46d9880ba3ac46c23a8253a4afcf2c169d6f4dc8
    Closes-Bug: 1368673

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
importance: Undecided → Medium
tags: added: horizon-core
Changed in horizon:
milestone: none → juno-rc1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.