Extend height of nav accordion

Bug #1365680 reported by Thai Tran
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Jiri Tomasek

Bug Description

Currently, the nav accordion appear like it is cut off and looks strange when user collapse or uncollapse the nav items. Since we are not using any spaces underneath the nav accordion, we should extend the height to 100%. This also brings us closer to the wireframe: http://people.redhat.com/~jcoufal/openstack/horizon/details/2014-02-19_details.pdf

Tags: ux ui
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/119183

Changed in horizon:
assignee: nobody → Thai Tran (tqtran)
status: New → In Progress
Revision history for this message
Thai Tran (tqtran) wrote :
tags: added: ui ux
Revision history for this message
Gary W. Smith (gary-w-smith) wrote :

The nav accordion does not look cut off to me; the thick border is drawn right below the nav tree, so it is clear where the menu ends.

The second page of the referenced wireframe document shows that the nav accordion does not extend the height to 100%.

Is this a valid change to make?

Revision history for this message
Thai Tran (tqtran) wrote :

Hm... good point, I missed that the 2nd page shows something different than 1st page. Let me run it by UX folks and get their opinion on this.

Revision history for this message
Cindy Lu (clu-m) wrote :
Revision history for this message
Aaron Sahlin (asahlin) wrote :

There is another patch addressing same issue.

https://review.openstack.org/#/c/126289/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Thai Tran (<email address hidden>) on branch: master
Review: https://review.openstack.org/119183
Reason: This solution proposed in this patch is not working. Getting resolve by https://review.openstack.org/#/c/126289/

Changed in horizon:
assignee: Thai Tran (tqtran) → Jiri Tomasek (jtomasek)
David Lyle (david-lyle)
Changed in horizon:
milestone: none → kilo-1
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/126289
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b8b1aa2acc6b06ca1a49f4ea9662b7632f7c1ab1
Submitter: Jenkins
Branch: master

commit b8b1aa2acc6b06ca1a49f4ea9662b7632f7c1ab1
Author: Jiri Tomasek <email address hidden>
Date: Thu Oct 2 17:45:06 2014 +0200

    Restyled sidebar to resemble UX guidelines

    Partially-Implements: blueprint navigation-styling
    Closes-Bug: #1365680

    Change-Id: I37e603ee5ba310ba5f18b69df4c1cd6fa529c1d9

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.