Cancel buttons in several dialogs missing border

Bug #1364644 reported by Julie Gravel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Gary W. Smith

Bug Description

When selecting 'View Custom Properties' from a row in the Admin Images table, you'll get to the Customer Properties table. From the table, you'll see the 'Create Property' table action and the 'Edit' row action. These two actions lead to the dialogs whose Cancel button are missing the border.

Tags: bootstrap
Changed in horizon:
assignee: nobody → Julie Gravel (julie-gravel)
Revision history for this message
Gary W. Smith (gary-w-smith) wrote :

'git grep' shows that a couple of additional pages have this same problem: openstack_dashboard/dashboards/admin/networks/templates/networks/agents/_add.html and openstack_dashboard/dashboards/project/databases/templates/databases/_resize_volume.html.

Changed in horizon:
status: New → Confirmed
importance: Undecided → Low
summary: - Cancel buttons in Create and Edit Custom Property dialogs missing border
+ Cancel buttons in several dialogs missing border
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/118480

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
Julie Gravel (julie-gravel) wrote :

This submit https://review.openstack.org/110789 will take care of the change for openstack_dashboard/dashboards/project/databases/templates/databases/_resize_volume.html.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/118755

Changed in horizon:
assignee: Julie Gravel (julie-gravel) → Gary W. Smith (gary-w-smith)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/118480
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2c32143ea677c3edf6ac20895056ee41bae1f6ee
Submitter: Jenkins
Branch: master

commit 2c32143ea677c3edf6ac20895056ee41bae1f6ee
Author: Julie Gravel <email address hidden>
Date: Tue Sep 2 03:12:04 2014 -0700

    Fix Cancel buttons in Custom Property dialogs

    This submit adds borders to the Cancel buttons of the Create Custom
    Property and the Edit Custom Property dialogs.

    Change-Id: I02f8f6032db5ba81c10f9073e6981f6fba87dfdd
    Partial-Bug: #1364644

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/118755
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=eb4d179bb7aa8da47596158cc40285f44ad8ef38
Submitter: Jenkins
Branch: master

commit eb4d179bb7aa8da47596158cc40285f44ad8ef38
Author: Gary W. Smith <email address hidden>
Date: Wed Sep 3 12:44:08 2014 -0700

    Fix Cancel button styling

    Add borders to the Cancel buttons in the affected html template

    Change-Id: I73769a854e8856c8fd759d972bf5adc61fb35666
    Partial-Bug: #1364644

Revision history for this message
Gary W. Smith (gary-w-smith) wrote :

Marking as Fix Committed since the remaining instances of this problem were handled in other changes.

Changed in horizon:
status: In Progress → Fix Committed
milestone: none → juno-rc1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.