stack parameters marked as hidden should use a password field

Bug #1362846 reported by Miguel Grinberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Miguel Grinberg

Bug Description

In the launch stack form, any heat template parameters that are marked as hidden are presented as a regular input field, exactly the same as a normal string field.

Given that hidden fields are marked as such due to their sensitive nature, it would be better to use a password entry field for them.

How to reproduce:

1. Use the following template:

heat_template_version: 2013-05-23
parameters:
  password:
    type: string
    hidden: true

2. Note how in the Launch Stack form for the above template the "password" field at the bottom shows characters as you type them.

Tags: heat
Changed in horizon:
assignee: nobody → Miguel Grinberg (miguelgrinberg)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/118420

Changed in horizon:
status: New → In Progress
Changed in horizon:
importance: Undecided → Medium
milestone: none → juno-3
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-3 → juno-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/118420
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=612ab2bceac496254bf9327d72db968de519567e
Submitter: Jenkins
Branch: master

commit 612ab2bceac496254bf9327d72db968de519567e
Author: Miguel Grinberg <email address hidden>
Date: Tue Sep 2 17:46:36 2014 +0000

    Render hidden stack parameters with a password field

    In the launch stack form, any heat template parameters that are
    of type string and marked as hidden are now rendered as a
    password field.

    Change-Id: Ie9b0a051a8815525c89de31b7ab98d8148166a55
    Closes-Bug: 1362846

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.