Port details overview Fixed IP field "none" not translated

Bug #1362200 reported by Aaron Sahlin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Aaron Sahlin

Bug Description

In /openstack_dashboard/dashboards/project/networks/templates/networks/ports/_detail_overview.html,
"None" is not translated. Should be {% trans "None" %}

    <dd>
      {% if port.fixed_ips.items|length > 1 %}
      {% for ip in port.fixed_ips %}
      <b>{% trans "IP address:" %}</b> {{ ip.ip_address }},
      <b>{% trans "Subnet ID" %}</b> {{ ip.subnet_id }}<br>
      {% endfor %}
      {% else %}
      "None"
      {% endif %}
    ...

Aaron Sahlin (asahlin)
Changed in horizon:
assignee: nobody → Aaron Sahlin (asahlin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/117268

Changed in horizon:
status: New → In Progress
Cindy Lu (clu-m)
Changed in horizon:
importance: Undecided → Low
Changed in horizon:
assignee: Aaron Sahlin (asahlin) → David Lyle (david-lyle)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/117268
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=08bc1db7a64c5cf1cea1232cc94785012adafe63
Submitter: Jenkins
Branch: master

commit 08bc1db7a64c5cf1cea1232cc94785012adafe63
Author: Aaron Sahlin <email address hidden>
Date: Wed Aug 27 09:44:58 2014 -0500

    Port details template missing some translation.

    There were hard coded "None" and "No attached device" strings
    in the port details overview template.

    Change-Id: I9b3fe24742da3974506d99b51b37c88b7d1ea446
    Closes-bug: #1362200

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
tags: added: i18n
Changed in horizon:
milestone: none → juno-3
assignee: David Lyle (david-lyle) → Aaron Sahlin (asahlin)
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.