Dynamic select widget layout problem when help block displayed

Bug #1361725 reported by Justin Pomeroy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Justin Pomeroy
Juno
Fix Released
Medium
Akihiro Motoki

Bug Description

When the help block is displayed, the dynamic select widget field does not correctly display the help below the field like the other input fields.

This is dependent on the fix to show the help block on modals:
https://review.openstack.org/#/c/111315/

Revision history for this message
Justin Pomeroy (jpomero) wrote :
Changed in horizon:
assignee: nobody → Justin Pomeroy (jpomero)
Revision history for this message
Justin Pomeroy (jpomero) wrote :

This is currently only an issue when using keystone v2 since v3 does not require the Primary Project field when creating a user.

Cindy Lu (clu-m)
Changed in horizon:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/117021

Changed in horizon:
status: Triaged → In Progress
Revision history for this message
Julie Pichon (jpichon) wrote :

Raising the priority, the form error looks silly without the fix and we'll likely want to backport it.

tags: added: juno-backport-potential
Changed in horizon:
importance: Low → Medium
Revision history for this message
Julie Pichon (jpichon) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/117021
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6a97012b2f6c4d5912e96d49968068300d138dd1
Submitter: Jenkins
Branch: master

commit 6a97012b2f6c4d5912e96d49968068300d138dd1
Author: Justin Pomeroy <email address hidden>
Date: Tue Aug 26 15:34:39 2014 -0500

    Fix dynamic select layout when help block is displayed

    This fixes the layout of the dynamic select widget when the help
    block is displayed. To reproduce this error you must be using the
    keystone v2 API so that the Primary Project field will be required
    when creating a user. If you leave it blank when submitting the
    form the help block will be displayed.

    Closes-Bug: #1361725
    Change-Id: Ied4bb5d22b7e8a1948330503516cba2aa016417f

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/130950

Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/juno)

Reviewed: https://review.openstack.org/130950
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8b0349f1c05f348aa425cded5c3e5902ce55e6fc
Submitter: Jenkins
Branch: stable/juno

commit 8b0349f1c05f348aa425cded5c3e5902ce55e6fc
Author: Justin Pomeroy <email address hidden>
Date: Tue Aug 26 15:34:39 2014 -0500

    Fix dynamic select layout when help block is displayed

    This fixes the layout of the dynamic select widget when the help
    block is displayed. To reproduce this error you must be using the
    keystone v2 API so that the Primary Project field will be required
    when creating a user. If you leave it blank when submitting the
    form the help block will be displayed.

    Closes-Bug: #1361725
    Change-Id: Ied4bb5d22b7e8a1948330503516cba2aa016417f
    (cherry picked from commit 6a97012b2f6c4d5912e96d49968068300d138dd1)

tags: added: in-stable-juno
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.