base template includes improper html

Bug #1359969 reported by Doug Fish
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Doug Fish

Bug Description

https://github.com/openstack/horizon/blob/a0f7235278cfe187b2ff31bfb787548735111c8b/horizon/templates/base.html#L40 contains a self-closing div tag. This is not a valid syntax for HTML5.

http://dev.w3.org/html5/html-author/#tags

Although I'm not aware of any specific wrong behaviors that result from this we should certainly make sure our pages are well-formed HTML

Doug Fish (drfish)
Changed in horizon:
assignee: nobody → Doug Fish (drfish)
Revision history for this message
Gary W. Smith (gary-w-smith) wrote :

This sounds reasonable. It would be nice to have html validation performed in a verification build to avoid other invalid syntax to creep in.

Changed in horizon:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/116112

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/116112
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f873284eb5d384305d0897cc49e2827ac89bb94a
Submitter: Jenkins
Branch: master

commit f873284eb5d384305d0897cc49e2827ac89bb94a
Author: Doug Fish <email address hidden>
Date: Thu Aug 21 16:41:28 2014 -0500

    Fix improper HTML in base template

    base.html includes a self closing div. This is not valid HTML.

    Change-Id: Iac2a26c05d5e0631c7294cd831e384fc223d955a
    Closes-bug: #1359969

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → juno-3
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.