Many CSS logic in inline-editing

Bug #1359637 reported by Thai Tran
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Thai Tran

Bug Description

We have way too many styling logic in our javascript files. This one focus particularly on the inline-editing tables. We need to isolate these logic and implement them in a CSS file where it belongs.

Changed in horizon:
assignee: nobody → Thai Tran (tqtran)
status: New → In Progress
Cindy Lu (clu-m)
Changed in horizon:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/115783
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=08cf2ce135e1eb41077387717f67125e4c4bccc8
Submitter: Jenkins
Branch: master

commit 08cf2ce135e1eb41077387717f67125e4c4bccc8
Author: Thai Tran <email address hidden>
Date: Thu Aug 21 02:53:50 2014 -0700

    Pulled CSS logic from inline-editing

    Too many "magic" numbers and styling logic in our javascript.
    This patch reassigned styling logic to CSS and removed the clutter.

    Change-Id: I2440bad2155fff3d2ba935ecfcc1e26a46f9b5d6
    Closes-Bug: #1359637

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → kilo-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-2 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.