Page refresh cancels modal dialog

[Timur Sufiev]

If you perform an operation that would display a green success message, but instead of waiting for that message you immediately launch another modal dialog, the modal will be cancelled when the table is refreshed and the message is displayed.

Steps to reproduce:
1. Go to Admin > Flavors and Edit a flavor.
2. Press Save (you don't even have to make any changes first)
3. After 'Working...' spinner disappears and the table is drawn and before the success message is displayed, immediately Edit another flavor (or even the some one, it doesn't matter).
4. The 'Loading...' spinner appears, and you may even get to see the dialog briefly.
5. The screen jumps back to the table (cancelling your dialog) and displays the 'Success' message.

This bug not only spoils UX, but also forces to add `time.sleep` into integration tests to make them pass.

[Gary W. Smith (gary-w-smith)]

I have not been able to reproduce the behavior described here, but I can get a similar behavior by skipping the wait in #3. In other words:
1. Go to Projects, click on 'Modify Quotas' for some project.
2. After quotas tab in modal form appears, change some quota value, click 'Submit'.
3. After 'Working...' spinner disappears and the table is drawn, BEFORE the success message is shown (you may have to be fast here), click on Modify Users (you can also click on Modify Quotas, but Modify Users is faster because there is no pulldown to wait for)
4. The 'Loading...' spinner appears, but when the Success message occurs (from the quota modification), the opening of the new modal will be aborted.

Is this the same behavior that you are seeing?

[Timur Sufiev (tsufiev-x)]

Yes, it is the same one! I was not fast enough to open another modal before success message appears :). But the Selenium in integration tests could do it.

[Gary W. Smith (gary-w-smith)]

I actually see this common behavior in a number of places in horizon. Basically if you try to bring up a modal dialog before the success message has been shown, the success message will interrupt the modal, even if the modal is already being displayed.

[Timur Sufiev (tsufiev-x)]

Gary, it seems to me that not the success message interrupts the modal, but the succeding page reload (caused by django redirect, which is used in Horizon to refresh the page after some changes were made in modal) does it.

[Gary W. Smith (gary-w-smith)]

(Modified the bug description to show steps that are a bit easier to reproduce)

[Gary W. Smith (gary-w-smith)]

Timur: Thanks, that is a more accurate description. I adjusted the text and header accordingly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/119793

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/119793
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f84243074851388f3b06ab8ec20eba1d804f75a5
Submitter: Jenkins
Branch: master

commit f84243074851388f3b06ab8ec20eba1d804f75a5
Author: Vlad Okhrimenko <email address hidden>
Date: Mon Sep 8 18:25:58 2014 +0300

    Disable buttons opening the modal forms on page unload

    If button which opens a modal form is clicked after page started
    reloading, form will disappear once reload is finished. To avoid this
    glitch make user unable to press such buttons until reload finishes.

    Change-Id: Id81a5e108644f99ee939296b54835f4f4ac2aaa7
    Closes-Bug: #1357331