Integration tests - selenium - public/private methods design flaw
Bug #1356774 reported by
Tomáš Nováčik
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Dashboard (Horizon) |
Fix Released
|
Wishlist
|
Daniel Korn |
Bug Description
There is flaw in horizon integration test design, certain methods located in the pageobject(those methods interact with webelements) should be executed only in the scope of class and definitely not touched in the test case. Problem is that those methods are public and thus nothing suggest that those methods should not be used in a test case(accessed as public method of page). Therefore i suggest to make those methods protected(make them start with the '_' prefix).
List of methods: is_element_visible, fill_field_element, select_dropdown, select_
Changed in horizon: | |
assignee: | nobody → Daniel Korn (dkorn) |
Changed in horizon: | |
status: | New → In Progress |
Changed in horizon: | |
assignee: | Daniel Korn (dkorn) → Tomáš Nováčik (tnovacik) |
tags: | added: integration-tests |
Changed in horizon: | |
assignee: | Tomáš Nováčik (tnovacik) → Daniel Korn (dkorn) |
Changed in horizon: | |
assignee: | Daniel Korn (dkorn) → Vlad Okhrimenko (vokhrimenko) |
Changed in horizon: | |
assignee: | Vlad Okhrimenko (vokhrimenko) → Daniel Korn (dkorn) |
Changed in horizon: | |
assignee: | Daniel Korn (dkorn) → Vlad Okhrimenko (vokhrimenko) |
Changed in horizon: | |
assignee: | Vlad Okhrimenko (vokhrimenko) → Daniel Korn (dkorn) |
Changed in horizon: | |
milestone: | none → kilo-1 |
Changed in horizon: | |
status: | Fix Committed → Fix Released |
Changed in horizon: | |
milestone: | kilo-1 → 2015.1.0 |
To post a comment you must log in.
Moving to wishlist as this is not a bug with horizon proper but a recommended improvement of the integration test code to facilitate identifying horizon bugs.