horizon/workflows/base.py contains add_error() which conflicts with Django 1.7 definition

Bug #1352919 reported by Thomas Goirand
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Wishlist
Thomas Goirand
Icehouse
Fix Released
Wishlist
Thomas Goirand

Bug Description

As per the subject, horizon/workflows/base.py contains a definition of add_error(). Unfortunately, this now a function name used by Django 1.7. This conflicts with it, and leads to unit test errors when running with Django 1.7 installed

Revision history for this message
Brad Pokorny (bpokorny) wrote :

This change has been submitted to fix this bug:
https://review.openstack.org/#/c/111930

Changed in horizon:
status: New → In Progress
Akihiro Motoki (amotoki)
Changed in horizon:
assignee: nobody → Thomas Goirand (thomas-goirand)
importance: Undecided → Wishlist
milestone: none → juno-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/111930
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=04dd1568c1c927901085941124e4c6852183f4f0
Submitter: Jenkins
Branch: master

commit 04dd1568c1c927901085941124e4c6852183f4f0
Author: Thomas Goirand <email address hidden>
Date: Tue Aug 5 14:50:06 2014 +0800

    Rename add_error methods: Django 1.7 conflict

    In Django 1.7, Forms have an add_error() method and our definition
    was conflicting with Django's method. Thanks to <email address hidden>
    for the patch.

    Close-bug: #1352919
    Change-Id: I1f558cf7f3198a68629738a011e9cae0c3749320

Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-3 → juno-rc1
David Lyle (david-lyle)
Changed in horizon:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/icehouse)

Reviewed: https://review.openstack.org/112630
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ad2d4281a38c168747c2bbe42513af72d4d7d0bd
Submitter: Jenkins
Branch: stable/icehouse

commit ad2d4281a38c168747c2bbe42513af72d4d7d0bd
Author: Thomas Goirand <email address hidden>
Date: Tue Aug 5 14:50:06 2014 +0800

    Rename add_error methods: Django 1.7 conflict

    In Django 1.7, Forms have an add_error() method and our definition
    was conflicting with Django's method. Thanks to <email address hidden>
    for the patch.

    Note that it is required to support Django 1.7 in Icehouse, because
    we're planning to release Debian Jessie with both Django 1.7 and
    Icehouse. This is to *support* Django 1.7, not at all to *switch* to
    it, which is very different.

    Close-bug: #1352919
    Change-Id: I1f558cf7f3198a68629738a011e9cae0c3749320
    (cherry picked from commit 04dd1568c1c927901085941124e4c6852183f4f0)

tags: added: in-stable-icehouse
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-rc1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.