typo in Step class docstring from horizon.workflows.base

[Tianpeng Wang]

In horizon/workflows/base.py

`.. attribute:: action` should be `.. attribute:: action_class`

[Rob Cresswell (robcresswell-deactivatedaccount)]

Any progress on this bug?

[Gary W. Smith (gary-w-smith)]

Please also make the correspondiong adjustment to the exception text when it is not set:
https://github.com/openstack/horizon/blob/master/horizon/workflows/base.py#L296

[Bhavani Shankar (bhavi)]

Is there any progress on this bug?

I have a trivial patch here attached for the same.

Hi Gary,

The exception text seems just fine I guess as the exception is raised when there is no action set and the docstring change would be mostly due to maintaining the consistency with the function name I think.

Please correct me if I am wrong somewhere

Regards
Bhavani

[Tianpeng Wang (timonwong)]

I haven't work on this bug yet, anyone who have fixes, feel free to commit the changes to gerrit.

@Bhavani
IMHO, It's a good idea to explicitly include the actual attribute name in the exception message, or you just get a attribute error with no idea about which attribute is wrong before reading the documentation or source code.

Sincerely,
Timon

[Bhavani Shankar (bhavi)]

Thanks Timon.

PFA updated trivial patch.

I'll open up a gerrit review tonight.

Regards
Bhavani

[Gary W. Smith (gary-w-smith)]

My point about fixing the exception was to change the text to reflect that an 'action_class' must be specified since it was still referring to the old name of 'action'

[Bhavani Shankar (bhavi)]

Thanks Gary.

Have submitted a review here:

https://review.openstack.org/115199

Regards
Bhavani

[Bhavani Shankar (bhavi)]

Didnt mention the bug number in the commit by mistake.

Manually setting this to fix committed

Regards
Bhavani