OpenStack Dashboard (Horizon)

All error messages are not displayed after form validation

Bug #1351298 reported by Ekaterina Chernova on 2014-08-01

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Dashboard (Horizon)	Fix Released	High	Timur Sufiev	OpenStack Dashboard (Horizon) 2014.2 "juno"

Bug Description

Steps to reproduce
--------------------------

1) Go to Project - > Access & Security page
2) Click "Create Key Pair" button
3) Type special symbols

Actual result
------------------

The field frame is red, but the error message is not appeard

The html page contains the following line:

<span class="help-block alert alert-danger " style="display: none;">Key pair name may only contain letters, numbers, underscores, spaces and hyphens.</span>

Expected result
----------------------
The error-message is displayed

It reproduces not only for that form, but for any other.

See original description

Revision history for this message

Ekaterina Chernova (efedorova) wrote on 2014-08-01:

No-error-message.png Edit (236.2 KiB, image/png)

Revision history for this message

Julie Pichon (jpichon) wrote on 2014-08-01:

The "display: none" style seems to be applied inline rather than come from a specific CSS class...

Changed in horizon:
status:	New → Confirmed
importance:	Undecided → High
milestone:	none → juno-3
summary:	- All error messages are not displaed after form validation + All error messages are not displayed after form validation

Ekaterina Chernova (efedorova) on 2014-08-01

description:

updated

Satyanarayana Patibandla (satya-patibandla) on 2014-08-01

Changed in horizon:
assignee:	nobody → Satyanarayana Patibandla (satya-patibandla)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-08-01: Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/111315

Changed in horizon:
assignee:	Satyanarayana Patibandla (satya-patibandla) → Timur Sufiev (tsufiev-x)
status:	Confirmed → In Progress

Revision history for this message

Timur Sufiev (tsufiev-x) wrote on 2014-08-01:

Satyanarayana, sorry, I started investigating this one without assigning it to myself here, but after I had uploaded it, I have noticed that you were also working on it. Perhaps you have some other ideas on how to fix it?

OpenStack Infra (hudson-openstack) on 2014-08-26

Changed in horizon:
assignee:	Timur Sufiev (tsufiev-x) → Justin Pomeroy (jpomero)

Timur Sufiev (tsufiev-x) on 2014-08-27

Changed in horizon:
assignee:	Justin Pomeroy (jpomero) → Timur Sufiev (tsufiev-x)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2014-08-27: Fix merged to horizon (master)

Reviewed: https://review.openstack.org/111315
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8f808a69f6f64c7d92571989b72da1d1801a1c86
Submitter: Jenkins
Branch: master

commit 8f808a69f6f64c7d92571989b72da1d1801a1c86
Author: Timur Sufiev <email address hidden>
Date: Fri Aug 1 19:29:16 2014 +0400

Show validation errors in modal forms

    Selector '.modal span.help-block' is the exact one for the
    validation messages. It might have been used for some
    other purpose previously, but now it breaks the things.

Change-Id: Ibb55f06533a21fc425a6bdac9b71b7e489223dd1
Closes-Bug: #1351298