There are hard-coded '/static/' url prefix in CSS (SCSS) and JS files

Bug #1342079 reported by Timur Sufiev on 2014-07-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Low
Timur Sufiev

Bug Description

Among the examples are:
https://github.com/openstack/horizon/blob/2014.2.b1/horizon/static/horizon/js/horizon.tables.js#L70
https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/dashboard/scss/_accordion_nav.scss#L17

This approach has the problem that if someone decides to serve static files from an url different from '/static/...', he would surely catch some 404 errors.

Fix proposed to branch: master
Review: https://review.openstack.org/112857

Changed in horizon:
assignee: nobody → Timur Sufiev (tsufiev-x)
status: New → In Progress
David Lyle (david-lyle) on 2014-08-11
Changed in horizon:
importance: Undecided → Low
milestone: none → juno-3

Reviewed: https://review.openstack.org/112857
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=806b626b28235873e7b2191cb8089350068e3a0e
Submitter: Jenkins
Branch: master

commit 806b626b28235873e7b2191cb8089350068e3a0e
Author: Timur Sufiev <email address hidden>
Date: Fri Aug 8 17:17:55 2014 +0400

    Remove hard-coded static prefix from JS and CSS files

    Use global variable STATIC_URL in JavaScript, use relative
    urls instead of absolute in CSS files.

    Change-Id: Ib89d95c4cb425479e3e7af3d8b38292b3a335faa
    Closes-Bug: #1342079

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx) on 2014-09-04
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx) on 2014-10-16
Changed in horizon:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers