some security rule template names should be translated

Bug #1334031 reported by Doug Fish
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack + Chef
Fix Released
Low
Doug Fish
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Doug Fish

Bug Description

In Projects->Access & Security->Security Groups->Manage Rules->Manage Rules->Add rule

Security group rule templates with the word "ALL" should be translated, and probably doesn't need to be all caps.

Doug Fish (drfish)
Changed in horizon:
assignee: nobody → Doug Fish (drfish)
Doug Fish (drfish)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/102378

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/102378
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=95904bde345ca7d4fdb92e2e68b84d20c926c0f0
Submitter: Jenkins
Branch: master

commit 95904bde345ca7d4fdb92e2e68b84d20c926c0f0
Author: Doug Fish <email address hidden>
Date: Tue Jun 24 17:33:26 2014 -0500

    Make security rules with All translatable

    The security rule names that include the word "All" should be
    translatable. I've included a SECURITY_GROUP_RULES value with
    the 3 translatable rules from local_settings.py.example so that
    we will actually have translations for those values.

    Change-Id: Id21ac0e6ea328ab18f35f7711de356015db5f50a
    Closes-bug: #1334031

Changed in horizon:
status: In Progress → Fix Committed
Doug Fish (drfish)
Changed in openstack-chef:
assignee: nobody → Doug Fish (drfish)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cookbook-openstack-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/104231

Changed in openstack-chef:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cookbook-openstack-dashboard (master)

Reviewed: https://review.openstack.org/104231
Committed: https://git.openstack.org/cgit/stackforge/cookbook-openstack-dashboard/commit/?id=23d746e9e1eca0a38f0f1450dc9b262087873840
Submitter: Jenkins
Branch: master

commit 23d746e9e1eca0a38f0f1450dc9b262087873840
Author: Doug Fish <email address hidden>
Date: Wed Jul 2 08:21:39 2014 -0500

    Make security rules with All translatable

    Use the python translation function on security rules which
    are not just acryonyms. Also there is no reason for the security
    rules to use the word "All" in all caps.

    Change-Id: Iaac4b01dfc096d589ac4a1e8c9ac772917b4942c
    Closes-Bug: #1334031

Changed in openstack-chef:
status: In Progress → Fix Released
Changed in horizon:
milestone: none → juno-2
status: Fix Committed → Fix Released
Changed in openstack-chef:
milestone: none → icehouse-rc1
Changed in openstack-chef:
milestone: icehouse-rc1 → icehouse-stable
Changed in openstack-chef:
importance: Undecided → Low
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-2 → 2014.2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/cookbook-openstack-dashboard ocata-eol

This issue was fixed in the openstack/cookbook-openstack-dashboard ocata-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.