Hide Host Aggregates panel if Nova does not support it

Bug #1332066 reported by Lin Hua Cheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Vlad Okhrimenko

Bug Description

Aggregates is a Nova extension, there is no guarantee that it would always be available. The panel should be hidden when Nova does not support it.

Tags: nova
Akihiro Motoki (amotoki)
tags: added: nova
Changed in horizon:
status: New → Confirmed
importance: Undecided → Low
Changed in horizon:
assignee: nobody → Richard Jones (r1chardj0n3s)
Changed in horizon:
status: Confirmed → In Progress
David Lyle (david-lyle)
Changed in horizon:
milestone: none → juno-3
Revision history for this message
Richard Jones (r1chardj0n3s) wrote :

I devised a simple change to the panel to fix this (https://review.openstack.org/#/c/117090/) but the change caused about half the 1000+ tests in the horizon suite to fail thanks to the delicate nature of the test setup.

I believe I would have to individually address each of those 498 test failures, modifying each test to make it work again, just to support the 2 lines I added to fix this bug.

I don't believe that's reasonable, so I invite anyone else to suggest a fix that breaks fewer tests :)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Richard Jones (<email address hidden>) on branch: master
Review: https://review.openstack.org/117090
Reason: This change results in far too much work to fix all the failing tests.

Revision history for this message
Richard Jones (r1chardj0n3s) wrote :

I've abandoned that change. Perhaps someone else might discover a way to fix this bug that won't take nearly as much effort.

Changed in horizon:
assignee: Richard Jones (r1chardj0n3s) → nobody
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-3 → juno-rc1
Changed in horizon:
assignee: nobody → Vlad Okhrimenko (vokhrimenko)
David Lyle (david-lyle)
Changed in horizon:
milestone: juno-rc1 → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/121127
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=4556bc808635d0f0b77139e6b1f2c25f3f4c1093
Submitter: Jenkins
Branch: master

commit 4556bc808635d0f0b77139e6b1f2c25f3f4c1093
Author: Vlad Okhrimenko <email address hidden>
Date: Fri Sep 12 16:54:47 2014 +0300

    Hide the "Host Aggregates" admin panel if not enabled

    This checks ether the extension is supported in nova and disables
    access to the panel (hiding it) if not.

    Closes-Bug: #1332066
    Change-Id: Ie6f5ec7a833d489adca6d56f34a39579e9eabdde

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.