hard coded urls should go away

Bug #1331429 reported by Matthias Runge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Bradley Jones

Bug Description

https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/metering/views.py#L128

that kind of url computation should be replaced by named urls:

 def get_context_data(self, **kwargs):
        context = {'tables': self.get_tables().values()}
        url = self.request.get_full_path().replace('/report', '/report/csv')
        context['csv_url'] = url
        return context

Changed in horizon:
status: New → Confirmed
Changed in horizon:
importance: Undecided → Low
Changed in horizon:
assignee: nobody → Bradley Jones (bradjones)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/115317

Changed in horizon:
status: Confirmed → In Progress
Changed in horizon:
milestone: none → juno-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/115317
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6db8a9885cea800051829eafa2bd9fdcb1a1ffe1
Submitter: Jenkins
Branch: master

commit 6db8a9885cea800051829eafa2bd9fdcb1a1ffe1
Author: Bradley Jones <email address hidden>
Date: Tue Aug 19 16:18:37 2014 +0100

    Remove hard coded URLs from metering view

    Now use reverse to lookup URL for report

    Change-Id: I9266459088c796d0caa7feb8f2ba4fb55bc8799a
    Closes-bug: 1331429

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.