Daily usage do not check date range validity

[Matthias Runge]

Visit
http://<host>/dashboard/admin/metering/report
and choose "other period"
For from/to take any value other than date.

This will result in ValueError at /admin/metering/report

Traceback:
File "/usr/lib/python2.7/site-packages/django/core/handlers/base.py" in get_response
  112. response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/usr/lib/python2.7/site-packages/horizon/decorators.py" in dec
  38. return view_func(request, *args, **kwargs)
File "/usr/lib/python2.7/site-packages/horizon/decorators.py" in dec
  86. return view_func(request, *args, **kwargs)
File "/usr/lib/python2.7/site-packages/horizon/decorators.py" in dec
  54. return view_func(request, *args, **kwargs)
File "/usr/lib/python2.7/site-packages/horizon/decorators.py" in dec
  38. return view_func(request, *args, **kwargs)
File "/usr/lib/python2.7/site-packages/horizon/decorators.py" in dec
  86. return view_func(request, *args, **kwargs)
File "/usr/lib/python2.7/site-packages/django/views/generic/base.py" in view
  69. return self.dispatch(request, *args, **kwargs)
File "/usr/lib/python2.7/site-packages/django/views/generic/base.py" in dispatch
  87. return handler(request, *args, **kwargs)
File "/usr/lib/python2.7/site-packages/horizon/tables/views.py" in post
  162. return self.get(request, *args, **kwargs)
File "/usr/lib/python2.7/site-packages/horizon/tables/views.py" in get
  154. handled = self.construct_tables()
File "/usr/lib/python2.7/site-packages/horizon/tables/views.py" in construct_tables
  137. tables = self.get_tables().values()
File "/usr/share/openstack-dashboard/openstack_dashboard/wsgi/../../openstack_dashboard/dashboards/admin/metering/views.py" in get_tables
  106. project_data = self.load_data(self.request)
File "/usr/share/openstack-dashboard/openstack_dashboard/wsgi/../../openstack_dashboard/dashboards/admin/metering/views.py" in load_data
  153. 3600 * 24)
File "/usr/share/openstack-dashboard/openstack_dashboard/wsgi/../../openstack_dashboard/dashboards/admin/metering/views.py" in query_data
  246. date_options)
File "/usr/share/openstack-dashboard/openstack_dashboard/wsgi/../../openstack_dashboard/dashboards/admin/metering/views.py" in _calc_date_args
  225. raise ValueError("The dates haven't been "

Exception Type: ValueError at /admin/metering/report
Exception Value: The dates haven't been recognized

[Matthias Runge (mrunge)]

By the way, the view should be changed to use http post instead of get!

[Nikunj Aggarwal (nikunj2512)]

I started working in this bug but i don't see from where i can select "choose "other period"" option.

It will be helpful, if You upload a screenshot.

[Julie Pichon (jpichon)]

1. Log in as admin
2. Go to Resource Usage
3. In the "Period" dropdown, choose "Other"

Hope this helps!

On the front-end side, ideally these forms should call the generic datepicker code that is used in other parts of Horizon (like e.g. the datepicker).

https://github.com/openstack/horizon/blob/2b2015a345/horizon/static/horizon/js/horizon.forms.js#L59

[Lawrance (jing)]

will try tomorrow!

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/107011

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/107011
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ca2e10c3e8efa6d5ae07a04ea0cd6a029dad7319
Submitter: Jenkins
Branch: master

commit ca2e10c3e8efa6d5ae07a04ea0cd6a029dad7319
Author: Matthias Runge <email address hidden>
Date: Tue Oct 14 11:26:42 2014 +0200

    Refactor metering dashboard

    - check date range for validity
    - use django forms
    - treat times according to users timezone

    Change-Id: I68182ddb4b00d19e54011722ebc770d9aa8e725c
    Closes-bug: #1331427
    Closes-bug: #1331434
    Closes-bug: #1288512