success_url is unneeded in PasswordView

Bug #1331329 reported by Zhenguo Niu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Zhenguo Niu

Bug Description

Since PasswordForm handle success return http.HttpResponseRedirect(settings.LOGOUT_URL), it's no need to set success_url in PasswordView.

see: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/settings/password/forms.py#L60

Changed in horizon:
assignee: nobody → Zhenguo Niu (niu-zglinux)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/100797

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/100797
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5f354a5cad700225eca15154fe97f299f94087fd
Submitter: Jenkins
Branch: master

commit 5f354a5cad700225eca15154fe97f299f94087fd
Author: Zhenguo Niu <email address hidden>
Date: Wed Jun 18 15:04:20 2014 +0800

    Remove the unused success_url and return

    Since 'Change Password' form handle successfully return
    httpResponseRedirect(settings.LOGOUT_URL), it's no need
    to set success_url and never reach the 'return True' at
    the end.

    Change-Id: I47c8888b07d06044fec8f06042d4ef6401e77097
    Closes-Bug: #1331329

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
milestone: none → juno-2
importance: Undecided → Low
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.