pagination and fixed filter will not work together

[Cindy Lu]

Steps to Reproduce:

1. Have several images
I have 2 Public and 5 Project images as displayed in Admin > Images. Please see (A) in attachment.
2. Now if you go to Project > Images, you will see at the top 3 buttons. For me it says: Project (5), Shared With Me (0) and Public (2)
3. If you click on those, they will show you the images in those categories (see (B) in attachment)

4. Now, check-out this patch: https://bugs.launchpad.net/horizon/+bug/1252649 to enable pagination on Project > Images
5. Go to Settings and set Items Per Page to 2
6. On Project > Images, it says Project (2), Shared With Me (0) and Public (1) (see (C) in attachment)

=> This is not accurate though. This is applying those filters on the *current items* displayed on the page. With pagination enabled those are only 2 items.

DRF Added: the Prev and Next buttons don't work quite as expected here either. I've included my scenario and notes in comments below.

Questions:
Do we want to pagination and fixed filter to work together? Or just stick with what we have now (even though Glance supports pagination)?

Possible solution:
I don't think we should use the FixedFilter. It seems like we plan on eventually supporting filtering by column and if we have both FixedFilter and Filter - that would be confusing. Maybe we can add a 'Category' column and have Project, Shared with Me and Public as entries. Then have a dropdown menu with the choice 'Category.' This would be align with the Admin > Instances filter. Something like this?

[Aaron Sahlin (asahlin)]

I prefer the proposed possible solution. Overall, as a product I think it is important to have consistent support across the different table views. Ignoring that for now..

What is the history / why does images use FixedFilter while other tables do not. Is there concern over the quantity of images, so we have a filter set initially? Or are Project, Shared with Me, and Public filters more important and warrant a higher level of visibility than the 'normal' table filter gives?

[Liz Blanchard (lblanchard)]

+1 to the proposed possible solution as well. I think once we have a solid solution for faceted search/filtering the fixed filter is no longer needed.

[Timur Sufiev (tsufiev-x)]

+1 for faceted search here. Setting Low priority to indicate alternative approach (faceted search) as the preferred one.

[Doug Fish (drfish)]

Doug's variation
1) set up an environment where there are 4 "Public" images and 1 "Project" image. Under settings keep items per page at 20 (the default) so that there will be no pagination and the right behavior can be seen
2) Navigate to Project->Compute->Images and note that there are accurate labels on the buttons -- Project (1) and Public (4). This is good.
3) Now under [user id]->settings, change the items per page to 2 - so that there will be pagination. Click Save
4) Navigate to Project->Compute->Images
     * Note that the Public button now says (2)
     * Note that the Project filter now has a "next" button, even though there is only 1 item
5) Click the Next button on the project filter.
     * Note that navigation switches to the Public filter.
    * Note that the project filter is now labelled Project (0)
6) Click the Prev button on the public filter.
    * Note that filtering switches to Project
7) Click the Public filter, Click, Next and then Prev
      * Note that filtering still switches to Project

[Doug Fish (drfish)]

I've tested out this scenario on Juno and Liberty code and somehow it works "fine", that is there is no pagination on the projects/images table.

The behavior is quite disruptive in master. I'm raising the priority. I favor the approach of removing the FixedFilter as well, though removing pagination is a viable alternative.

[Eddie Ramirez (ediardo)]

Bug not valid in Newton, now using ngImages.