Unexpected messages during running of runtests.sh

Bug #1329391 reported by Abishek Subramanian
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Richard Jones

Bug Description

Latest upstream master branch seems to have two distinct issues when ./runtests.sh is run.

First is a series of HTTP connection errors timing out and slowing down the execution of the entire runtest suite -

DEBUG:cinderclient.client:Connection refused: HTTPConnectionPool(host='public.nova.example.com', port=8776): Max retries exceeded with
url: /v1/os-quota-sets/1/defaults (Caused by <class 'socket.error'>: [Errno 110] Connection timed out)
.INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): public.nova.example.com

The second is a bunch of console debug messages and tracebacks that get printed out in the middle of the test suite -

Expected failure.
Traceback (most recent call last):
  File "/opt/stack/horizon/openstack_dashboard/dashboards/project/instances/console.py", line 47, in get_console
    console = api_call(request, instance.id)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/mox.py", line 765, in __call__
    return mock_method(*params, **named_params)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/mox.py", line 1010, in __call__
    raise expected_method._exception
ClientException: Expected failure.
Expected failure.
Traceback (most recent call last):
  File "/opt/stack/horizon/openstack_dashboard/dashboards/project/instances/console.py", line 47, in get_console
    console = api_call(request, instance.id)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/mox.py", line 765, in __call__
    return mock_method(*params, **named_params)
  File "/opt/stack/horizon/.venv/local/lib/python2.7/site-packages/mox.py", line 1010, in __call__
    raise expected_method._exception
ClientException: Expected failure.
....Console type "FAKE" not supported.

Both need to be fixed/removed/addressed to ensure ./runtests is run without added delay and console messages.
It doesn't seem like there are any actual test failures or errors - just added delays and console messages.

Revision history for this message
Julie Pichon (jpichon) wrote :

The "FAKE" issue is being tracked in bug 1322262 and already has a patch up for review. The "Connection Refused" is likely due to missing mocks and needs to be fixed. Running the tests with increased verbosity reveals the problem is coming from the following tests:

test_cinder_services_index (openstack_dashboard.dashboards.admin.info.tests.SystemInfoViewTests)
test_default_quotas_index (openstack_dashboard.dashboards.admin.info.tests.SystemInfoViewTests)
test_default_quotas_index_with_neutron_disabled (openstack_dashboard.dashboards.admin.info.tests.SystemInfoViewTests)
test_default_quotas_index_with_neutron_sg_disabled (openstack_dashboard.dashboards.admin.info.tests.SystemInfoViewTests)
test_index (openstack_dashboard.dashboards.admin.info.tests.SystemInfoViewTests)

Changed in horizon:
status: New → Triaged
importance: Undecided → Medium
milestone: none → juno-2
Revision history for this message
Abishek Subramanian (absubram) wrote :

Thanks for the info Julie. You're right - it is those tests that is slowing things down.
Looks like this merge - https://github.com/openstack/horizon/commit/03ed6e1ad1fe96c020d5031f2610c3e67a75d8a3
seems to have added a new "Cinder Services" tab and that's causing these HTTP connection failures.

Changed in horizon:
assignee: nobody → Gary W. Smith (gary-w-smith)
Changed in horizon:
assignee: Gary W. Smith (gary-w-smith) → nobody
Revision history for this message
Richard Jones (r1chardj0n3s) wrote :

The FAKE issue has been resolved per bug 1322262.

I can't reproduce the slow-down issue, but I do see those error messages display and they were annoying me, so I'll fix the missing mocks.

Changed in horizon:
assignee: nobody → Richard Jones (r1chardj0n3s)
Revision history for this message
Julie Pichon (jpichon) wrote :

Thanks Richard! I find this pretty annoying as well, if you need a hand with anything or have questions about this bug feel free to ask and/or pop up on #openstack-horizon.

Changed in horizon:
status: Triaged → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/104748

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/104748
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ff6425bf2071e8f8589c450c53ff6f608290d5e1
Submitter: Jenkins
Branch: master

commit ff6425bf2071e8f8589c450c53ff6f608290d5e1
Author: Richard Jones <email address hidden>
Date: Thu Jul 3 18:00:34 2014 +1000

    Implement missing mocks to remove error noise during test run

    Several cinder API mocks were missing from these tests. This patch
    adds those so the error noise reported in bug 1329391 is removed.

    Change-Id: Ib0ca72ff0df92d1c5187a86469ea7fc93873de11
    Closes-Bug: 1329391

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.