Refactoring: support session/cookie getters and setters

Bug #1329369 reported by Ana Krivokapić
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Wishlist
Ana Krivokapić

Bug Description

In https://github.com/openstack/horizon/blob/master/horizon/utils/functions.py, there is a function called get_page_size() which is used to get the value of the page size parameter from the session and/or cookie. We should refactor this part of code, by adding a pair of generic getter/setter functions which can be used to get arbitrary values from the session/cookie. More specific functions which deal with particular session/cookie values in specific ways can then be implemented, and they will call the generic getters/setters.

Revision history for this message
Gary W. Smith (gary-w-smith) wrote :

That would be a nice improvement.

Changed in horizon:
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/155939

Changed in horizon:
status: Confirmed → In Progress
Changed in horizon:
milestone: none → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/155939
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=00958cd40df2c90d3d6d1fc889c82e9dca651856
Submitter: Jenkins
Branch: master

commit 00958cd40df2c90d3d6d1fc889c82e9dca651856
Author: Ana Krivokapic <email address hidden>
Date: Sat Feb 14 01:47:41 2015 +0100

    Add generic session/cookie value getters/setters

    Change-Id: I116b67da2c8acd05b2ec05791875cad3c6f7bb2d
    Closes-Bug: #1329369

Changed in horizon:
status: In Progress → Fix Released
Changed in horizon:
milestone: next → ocata-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 11.0.0.0b3

This issue was fixed in the openstack/horizon 11.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.