Allow for editing of existing Security Rules

Bug #1326124 reported by Matt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Won't Fix
Wishlist
David Cusatis
neutron
Expired
Wishlist
Unassigned

Bug Description

Currently in the Horizon UI, after adding a security rule you can only delete it. If you mess up one of the fields, there's no edit option available where you could see the create dialog again, flip it from TCP to UDP or whatever you forgot to do, and then update the rule. You've got to remember everything you need to fill out, delete it, and then create it properly.

It'd be much simpler if users could edit a security rule group, instead of having to delete and recreate.

If there's nothing in nova that lets us edit a rule, could we fake it in the UI and when they "edit" a rule, we just pull out all the configured info, populate a create dialog with it, and then when they click save, it deletes the old rule and creates the updated one?

As someone who has entered lots of security rules, I can tell you firsthand that it's really demoralizing when you realize you forgot to change TCP to UDP on your otherwise correct rule after creating it, and have to delete it and try again, remembering which position you were in on your port table so you don't start entering a different rule...

Tags: api sg-fw ux
Revision history for this message
Julie Pichon (jpichon) wrote :

From past experience (...editing flavours comes to mind), it's generally unwise for Horizon to try to work around limitations in the other services and attempt to provide additional features not supported by the APIs. This tends to cause bugs and confusion. I think the right way to go about this would be to convince the other services to add an API that lets you do this first.

There is additional complexity in managing security groups in that the functionality can be provided by either Nova or Neutron (Horizon supports both). Looking at the respective clients' help, currently neither appears to provide a way to edit rules... I'll add a task on Nova and Neutron to see what they think about this.

I suppose one of the main issue with editing flavours was that the id matters one way or the other, so perhaps we could work around the API limitations somewhat more transparently here...

tags: removed: low-hanging-fruit
Changed in neutron:
status: New → Confirmed
tags: added: sg-fw
tags: added: api
Changed in neutron:
importance: Undecided → Wishlist
Julie Pichon (jpichon)
Changed in horizon:
status: New → Confirmed
importance: Undecided → Wishlist
Changed in nova:
importance: Undecided → Wishlist
status: New → Confirmed
jichenjc (jichenjc)
Changed in nova:
assignee: nobody → jichenjc (jichenjc)
Revision history for this message
jichenjc (jichenjc) wrote :

this patch need API changes and according to [1][2], it might not be finished in Juno
so will start to work on it and see whether it can be accepted as specs for K release

http://lists.openstack.org/pipermail/openstack-dev/2014-June/037536.html
http://lists.openstack.org/pipermail/openstack-dev/2014-June/038475.html

Wei Wang (damon-devops)
Changed in neutron:
assignee: nobody → Wei Wang (damon-devops)
David Cusatis (dcusati)
Changed in horizon:
assignee: nobody → David Cusatis (davidcusatis)
David Cusatis (dcusati)
Changed in horizon:
assignee: David Cusatis (dcusati) → nobody
David Cusatis (dcusati)
Changed in horizon:
assignee: nobody → David Cusatis (dcusati)
Sean Dague (sdague)
Changed in nova:
status: Confirmed → Opinion
Revision history for this message
Armando Migliaccio (armando-migliaccio) wrote :

This bug is > 180 days without activity. We are unsetting assignee and milestone and setting status to Incomplete in order to allow its expiry in 60 days.

If the bug is still valid, then update the bug status.

Changed in neutron:
assignee: Wei Wang (damon-devops) → nobody
status: Confirmed → Incomplete
Revision history for this message
Akihiro Motoki (amotoki) wrote :

Nova security group API has been dropped in the latest Nova REST API (I don't check the exact micro version though), so this bug no longer affects Nova.

no longer affects: nova
Revision history for this message
Akihiro Motoki (amotoki) wrote :

In neutron development, this topic failed to gather attraction, and neutron team has not received this kind of requests except this one.

As horizon, this bug has no activity for a long time as well.

Considering this situation, I would like to mark this as Won't Fix (for both horizon and neutron).

Changed in horizon:
status: Confirmed → Won't Fix
Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for neutron because there has been no activity for 60 days.]

Changed in neutron:
status: Incomplete → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.