Images dashboard - term consistency 'no' vs 'False'

Bug #1325138 reported by Cindy Lu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Cindy Lu

Bug Description

In Images table, Public and Protected columns say either Yes/No.
If you click on an image to get "Image Details", Public and Protected say either True/False.

We should stick with one.

Cindy Lu (clu-m)
summary: - Images dashboard - term consistency
+ Images dashboard - term consistency 'no' vs 'False'
Revision history for this message
Ashish Chandra (ashish-chandra) wrote :

Nice catch, for consistency we should have a common convention. IMHO, we should go with YES/NO instead of TRUE/FALSE.

Changed in horizon:
status: New → Confirmed
Cindy Lu (clu-m)
Changed in horizon:
assignee: nobody → Cindy Lu (clu-m)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/97876

Changed in horizon:
status: Confirmed → In Progress
Changed in horizon:
importance: Undecided → Low
milestone: none → juno-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/97876
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=24aa45aae32ac3032884a6031e21437ff19094db
Submitter: Jenkins
Branch: master

commit 24aa45aae32ac3032884a6031e21437ff19094db
Author: Cindy Lu <email address hidden>
Date: Wed Jun 4 11:32:16 2014 -0700

    Images table/detail view term consistency

    Table uses Yes/No in Public and Protected columns
    Detail View uses True/False

    => Make Detail View say Yes/No too

    Change-Id: Ib6852be79613ae4deea602c2ee42e036f0fed517
    Closes-Bug: #1325138

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.