Automatically discover Image Format based on image file extension

Bug #1324192 reported by Liz Blanchard
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Wishlist
Shuichiro MAKIGAKI

Bug Description

It would be great if Horizon could automatically prepopulate the "Format" field in the Create Image modal after the user has filled out the Image Source/Image File fields. This could be done based on the file extension and save the user from filling out one additional field in this modal.

Revision history for this message
Shuichiro MAKIGAKI (shuichiro-makigaki) wrote :

Sounds good. I'd like to take this over.

Changed in horizon:
assignee: nobody → Shuichiro MAKIGAKI (shuichiro-makigaki)
Revision history for this message
Cindy Lu (clu-m) wrote :

Hi guys,

I like this idea, but what about things like: http://uec-images.ubuntu.com/precise/current/precise-server-cloudimg-amd64-disk1.img? (from http://docs.openstack.org/image-guide/content/ch_obtaining_images.html)

this is a qcow2 format, but the file ext doesn't convey that.

Revision history for this message
Shuichiro MAKIGAKI (shuichiro-makigaki) wrote :

Yes, your question is reasonable.
However, I think it's ok to keep "Format" blank in that case. This means it keeps "Format" blank if it can't detect image format from file extension.

Actually, it's difficult to detect actual image format unless the image is uploaded.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/98995

Changed in horizon:
status: New → In Progress
Julie Pichon (jpichon)
Changed in horizon:
importance: Undecided → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/98995
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c16baae8fb66b50347c68aee6d3dab6cf8a4ede4
Submitter: Jenkins
Branch: master

commit c16baae8fb66b50347c68aee6d3dab6cf8a4ede4
Author: Shuichiro MAKIGAKI <email address hidden>
Date: Tue Jun 10 18:32:00 2014 +0900

    Automatically discover "Image Format" based on file extension

    This commit can automatically pre-populate the "Format" field in
    the "Create Image" modal after the user has filled out the "Image
    Source" or "Image File" fields. This can be done based on the file
    extension and save the user from filling out one additional field
    in this modal.

    Change-Id: Id6e3f3b3f8e354ce077a8f05f2bd5029b7fa9628
    Closes-Bug: #1324192

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → juno-3
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.