Only "btn-danger" type action buttons update based on row selection

Bug #1319458 reported by Justin Pomeroy
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Justin Pomeroy

Bug Description

The table actions are currently enabled or disabled based on row selection if they use the "btn-danger" class. The problem is this class is meant for actions such as delete and also adds the red styling. Therefore there is no way to add a "non dangerous" batch action to the table actions and have it update based on selection.

Justin Pomeroy (jpomero)
Changed in horizon:
assignee: nobody → Justin Pomeroy (jpomero)
Justin Pomeroy (jpomero)
Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/103638

Revision history for this message
Doug Fish (drfish) wrote :

This seems like a good enablement and makes the code work like it really should.

Changed in horizon:
importance: Undecided → Low
Revision history for this message
Ana Krivokapić (akrivoka) wrote :

This bug also directly affects Tuskar-UI, as we currently have non-danger batch action buttons there. Upping the importance.

Changed in horizon:
importance: Low → Medium
Changed in horizon:
milestone: none → kilo-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/103638
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=0b2e47520f8bf3cd6278e2246dfb25d090af2edf
Submitter: Jenkins
Branch: master

commit 0b2e47520f8bf3cd6278e2246dfb25d090af2edf
Author: Justin Pomeroy <email address hidden>
Date: Wed May 14 10:37:01 2014 -0500

    Update state of table batch actions based on row selection

    This fixes the problem where only buttons having the class
    "btn-danger" are enabled or disabled based on row selection.
    Button state will now be updated for all table batch actions.

    Closes-Bug: 1319458
    Change-Id: I9f51672781b294abe8385ef9576653ebd6f1bf43

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.