Database Launch Form shouldn't autocomplete.

Bug #1316226 reported by Matthew D. Wood
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Matthew D. Wood

Bug Description

On the Database Launch page, the form-element's attributes should include 'autocomplete="off"'.

I previously thought there wasn't a mechanism to do this, but after coding up a big solution, I found the in-place mechanism.

------ OLD BUG DESCRIPTION BELOW -----

Currently, there's no mechanism to set a Workflow's form element's "autocomplete" attribute.

This mechanism exists within modal-forms; through a template inheritance mechanism. That approach doesn't work for workflows because the template-inheritance is reversed.

One good example of a Workflow that should have the 'autocomplete="off"' tag is the database launch page. (Which, unsurprisingly, provided me the motivation to submit the bug in the first place.)

Changed in horizon:
assignee: nobody → Matthew D. Wood (woodm1979)
description: updated
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/92168

Changed in horizon:
status: New → In Progress
Revision history for this message
Matthew D. Wood (woodm1979) wrote : Re: Autocomplete attribute for Workflow forms

In looking a bit more, there really is a mechanism to set attributes, it just wasn't immediately obvious. I'm going to re-do this bug.

summary: - Autocomplete attribute for Workflow forms
+ Database Launch Form shouldn't autocomplete.
description: updated
David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Medium
milestone: none → juno-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/92168
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=4feff889be1e89b11c31091a88f5df265d1c8a2c
Submitter: Jenkins
Branch: master

commit 4feff889be1e89b11c31091a88f5df265d1c8a2c
Author: woodm1979 <email address hidden>
Date: Mon May 5 10:57:26 2014 -0600

    Database Launch Form shouldn't autocomplete

    The form element on the Database Launch page should have the attribute:
    autocomplete="off" set.

    I finally found the mechanism to add attributes to workflow-forms, so
    please ignore my first change-set. :-)

    Change-Id: I3f7f4a24580bd2fa5a40ed673a8d33d81e6e9659
    Closes-Bug: 1316226

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.