Left side navigation doesn't show focus

Bug #1315488 reported by Doug Fish
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Unassigned

Bug Description

This bug is an accessibility problem

guideline violated
http://www.w3.org/TR/UNDERSTANDING-WCAG20/navigation-mechanisms-focus-visible.html

testing technique:
Use the tab key to navigate the Horizon UI. Notice that along the header area the tenant switcher, profile switcher, and signout link have a dotted rectangle displaying focus. When the left side navigation is reached no outline is displayed.

How are we going to fix this?
The fix will likely involve adding a :focus style to make sure an outline or some other shading is shown

Julie Pichon (jpichon)
tags: added: accessibility
Changed in horizon:
status: New → Confirmed
importance: Undecided → Medium
tinytmy (tangmeiyan77)
Changed in horizon:
assignee: nobody → tinytmy (tangmeiyan77)
Changed in horizon:
assignee: tinytmy (tangmeiyan77) → dominik dobruchowski (dominik-dobruchowski)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/131501

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/131501
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

Removed assignee due to inactivity.

Changed in horizon:
assignee: dominik dobruchowski (dominik-dobruchowski) → nobody
status: In Progress → Confirmed
milestone: none → ongoing
Changed in horizon:
milestone: ongoing → next
Changed in horizon:
assignee: nobody → Rob Cresswell (robcresswell)
Changed in horizon:
status: Confirmed → In Progress
Changed in horizon:
assignee: Rob Cresswell (robcresswell) → Diana Whitten (hurgleburgler)
Changed in horizon:
assignee: Diana Whitten (hurgleburgler) → Rob Cresswell (robcresswell)
Changed in horizon:
milestone: next → newton-rc1
Changed in horizon:
milestone: newton-rc1 → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/297733
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=837587fe73066d23134c77ad92e283fe240b40d1
Submitter: Jenkins
Branch: master

commit 837587fe73066d23134c77ad92e283fe240b40d1
Author: Rob Cresswell <email address hidden>
Date: Mon May 16 15:34:34 2016 +0100

    Improve Horizon nav sidebar

    - Make menu responsive (hides on smaller screens, e,g, 1/2 laptop screen,
      tablet, mobile)
    - Add aria parameters for accessibility
    - Show current focus when navigating (accessibility)
    - Remove the blue outline when clicking links in Chrome
    - Makes menu less hideous

    Change-Id: I1cdfa079f0b371d1afddefa67d8a21e93abde9ee
    Implements: blueprint navigation-improvements
    Closes-Bug: 1315488
    Closes-Bug: 1628274

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/403810

Changed in horizon:
milestone: next → ocata-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/newton)

Reviewed: https://review.openstack.org/403810
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=bdd9854c47ec08030dec587e021fccac3b72d221
Submitter: Jenkins
Branch: stable/newton

commit bdd9854c47ec08030dec587e021fccac3b72d221
Author: Rob Cresswell <email address hidden>
Date: Mon May 16 15:34:34 2016 +0100

    Improve Horizon nav sidebar

    - Make menu responsive (hides on smaller screens, e,g, 1/2 laptop screen,
      tablet, mobile)
    - Add aria parameters for accessibility
    - Show current focus when navigating (accessibility)
    - Remove the blue outline when clicking links in Chrome
    - Makes menu less hideous

    Change-Id: I1cdfa079f0b371d1afddefa67d8a21e93abde9ee
    Implements: blueprint navigation-improvements
    Closes-Bug: 1315488
    Closes-Bug: 1628274
    (cherry picked from commit 837587fe73066d23134c77ad92e283fe240b40d1)

tags: added: in-stable-newton
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 11.0.0.0b2

This issue was fixed in the openstack/horizon 11.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 10.0.2

This issue was fixed in the openstack/horizon 10.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.