Missing comma in the _attrs of Volume Resource Wrapper

Bug #1308642 reported by Lin Hua Cheng
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Lin Hua Cheng
Icehouse
Fix Released
High
Julie Pichon

Bug Description

Missing comma after 'bootable'

https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/cinder.py#L81

class Volume(BaseCinderAPIResourceWrapper):

    _attrs = ['id', 'name', 'description', 'size', 'status', 'created_at',
              'volume_type', 'availability_zone', 'imageRef', 'bootable'
              'snapshot_id', 'source_volid', 'attachments', 'tenant_name',
              'os-vol-host-attr:host', 'os-vol-tenant-attr:tenant_id',
              'metadata']

Floren (florenllanos)
Changed in horizon:
status: New → Confirmed
tags: added: low-hanging-fruit
Changed in horizon:
assignee: nobody → Robert Mizielski (miziel-r)
Changed in horizon:
status: Confirmed → Triaged
importance: Undecided → High
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/88212

Changed in horizon:
status: Triaged → In Progress
Revision history for this message
Robert Mizielski (miziel-r) wrote :

Lin Hua Cheng fixed this, review is here: https://review.openstack.org/#/c/88021/

Julie Pichon (jpichon)
Changed in horizon:
assignee: Robert Mizielski (miziel-r) → Lin Hua Cheng (lin-hua-cheng)
tags: added: icehouse-backport-potential
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/88021
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c45449c3a979c15ae414934fe162fbb4f0502ba0
Submitter: Jenkins
Branch: master

commit c45449c3a979c15ae414934fe162fbb4f0502ba0
Author: Lin Hua Cheng <email address hidden>
Date: Wed Apr 16 09:36:27 2014 -0700

    Add missing comma in Volume ResourceWrapper class

    Change-Id: Ie0b0f40966f6bf98f693a971fdb498537842b21e
    Closes-Bug: #1308642

Changed in horizon:
status: In Progress → Fix Committed
Julie Pichon (jpichon)
Changed in horizon:
milestone: none → juno-1
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix proposed to horizon (stable/icehouse)

Fix proposed to branch: stable/icehouse
Review: https://review.openstack.org/88350

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to horizon (stable/icehouse)

Reviewed: https://review.openstack.org/88350
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=fbd5b2e3668989a78f55e1a16a5ab0455d1acb83
Submitter: Jenkins
Branch: stable/icehouse

commit fbd5b2e3668989a78f55e1a16a5ab0455d1acb83
Author: Lin Hua Cheng <email address hidden>
Date: Wed Apr 16 09:36:27 2014 -0700

    Add missing comma in Volume ResourceWrapper class

    Change-Id: Ie0b0f40966f6bf98f693a971fdb498537842b21e
    Closes-Bug: #1308642
    (cherry picked from commit c45449c3a979c15ae414934fe162fbb4f0502ba0)

Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.