wrong event expectation in _attachInputHandlers

Bug #1306177 reported by Valeriy Ponomaryov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Invalid
Undecided
Unassigned

Bug Description

file horizon/static/horizon/js/horizon.quota.js

Usage of 'data-progress-indicator-for' depends on 'keyup' event.
In google chromium we can change value of input with arrows of increasing and decreasing of integer values.
It makes only 'change' event without 'keyup'.

Place with error - gigabyte quotas in volume creation dialog for cinder. (see attachment)

Revision history for this message
Valeriy Ponomaryov (vponomaryov) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/86661

Changed in horizon:
assignee: nobody → Valeriy Ponomaryov (vponomaryov)
status: New → In Progress
Revision history for this message
Cristian Fiorentino (cristian-fiorentino) wrote :

Question: does this bug refer to adding the arrows in the Volume size field (with i.e. the mouse), for enhancing the usability when creating a volume using Google Chrome?

Revision history for this message
Valeriy Ponomaryov (vponomaryov) wrote :

Arrows are feature of google chromium, they are not the html elements.

Core idea - with such feature we don't make 'keyup' and 'keydown' events changing int values with arrows, only 'change' event appears.
In FF there are all of these events appears(no arrows, only manual changes), so there it works with 'keyup' and 'change' events.

Actually, I think better to hang both event listeners here. Because 'change' can be called after 'keyup'. And time between these events can be long and user can expect reaction in it.

description: updated
Revision history for this message
Cristian Fiorentino (cristian-fiorentino) wrote :

I have tried the patch using FF and Chrome (over Ubuntu); and in any case I find the arrows showed in the screenshot.
Is there any particular Chrome version where arrows appear?

Revision history for this message
Valeriy Ponomaryov (vponomaryov) wrote :

I used "Chromium":
Version 33.0.1750.152 Ubuntu 12.04 (256984)

Revision history for this message
Cristian Fiorentino (cristian-fiorentino) wrote :

I still cannot reproduce the issue.
I have installed the mentioned version of Chromium and still cannot see the arrows behavior in the Volume Size field.

Revision history for this message
Valeriy Ponomaryov (vponomaryov) wrote :

Arrows appear after hovering input for volume size.

Revision history for this message
Cristian Fiorentino (cristian-fiorentino) wrote :

Thanks Valeriy, but I still cannot reproduce this; on creating a new Volume, and entering a number there.. and then clicking, focusing, mouse over, etc... I cannot see the arrows :(

Revision history for this message
Cristian Fiorentino (cristian-fiorentino) wrote :

Having tried the issue with the mentioned software versions, and not being able to reproduce it I would suggest to offer more details on the way to reproduce the issue.

Revision history for this message
Valeriy Ponomaryov (vponomaryov) wrote :

Cristian:

It appears on input element, if it's type "number". Arrows are absent, if input element has "text" type.
To test it, just modify type of input with "Chrome Dev Tools".

Didn't find reason of differents types. On one machine I have, by default, 'number', on another "text".

Changed in horizon:
assignee: Valeriy Ponomaryov (vponomaryov) → nobody
Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :

This no longer appears to be a bug.

Changed in horizon:
status: In Progress → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.