mishandled error on key-pair generation

[Matthew D. Wood]

While generating a key-pair, certain exceptions aren't being handled correctly in that they aren't being redirected.

This leaves us with a NameError on <keypair> after the exception was supposed to be handled.

[code]
class GenerateView(View):
    def get(self, request, keypair_name=None):
        try:
            keypair = api.nova.keypair_create(request, keypair_name)
        except Exception:
            redirect = reverse('horizon:project:access_and_security:index')
            exceptions.handle(self.request,
                              _('Unable to create key pair: %(exc)s'),
                              redirect=redirect)
            raise exceptions.Http302(redirect)

        response = http.HttpResponse(content_type='application/binary')
        response['Content-Disposition'] = \
                'attachment; filename=%s.pem' % slugify(keypair.name)
        response.write(keypair.private_key)
        response['Content-Length'] = str(len(response.content))
        return response
[/code]

I know that Unauthorized exceptions aren't redirected inside exceptions.handle, even if a redirect is specified. There may be other exceptions that slip through, I've been mystified by this type of thing in the past.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/86649

[Julie Pichon (jpichon)]

I think this is a duplicate of bug 1299126 (the fix certainly appears to be the same), even though the exception names mentioned seem to be different. Feel free to reopen if I am mistaken, thank you.

[Matthew D. Wood (woodm1979)]

@jpichon, I think you're right. I'll close out this bug and kill the review. Nice catch!