action title can oveflow pulldown menu when action title is long

Bug #1300868 reported by Akihiro Motoki
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Lin Hua Cheng

Bug Description

When an action title of pulldown menu is long, the action title can overflow the pulldown menu.
It is found during checking Japanese translation.
https://cloud.githubusercontent.com/assets/6553985/2580835/d08465a4-b9b1-11e3-9262-8509ab3589ed.png

It would be nice if a width of a pulldown menu fits the longest title of pulldown menus.

Tags: ux
Akihiro Motoki (amotoki)
tags: added: ux
Revision history for this message
David Lyle (david-lyle) wrote :

Additional info, this only occurs for the danger (red) actions, other actions cause the size of the dropdown to grow.

Changed in horizon:
status: New → Confirmed
importance: Undecided → Low
Changed in horizon:
assignee: nobody → Pablo Fernando Cargnelutti (pablo-fernando-cargnelutti)
Revision history for this message
Pablo Fernando Cargnelutti (pablo-fernando-cargnelutti) wrote :

I cannot reproduce it for instances actions in Japanese language. Is there any specific place where it happens?

Revision history for this message
Akihiro Motoki (amotoki) wrote :

AFAIK, it occurs only in "Delete Volume Snapshot" action in "Volume Snapshot" table.

# Translators tried to shorten the string length but the string is reused in other places and could not change the string.

Revision history for this message
Akihiro Motoki (amotoki) wrote :

I confirmed it has been fixed in Juno cycle (though I didn't identify which commit fixed the issue).

Changed in horizon:
milestone: none → juno-rc1
status: Confirmed → Won't Fix
status: Won't Fix → Fix Committed
Revision history for this message
Gary W. Smith (gary-w-smith) wrote :

It was reported in https://bugs.launchpad.net/horizon/+bug/1372909 that this problem is still present

Revision history for this message
Julie Pichon (jpichon) wrote :

Clearing status based on last comment or no one will pick it up.

(I'm clearing the status because there's actually no patch associated with this bug report. If there had been I think it'd be more appropriate to open a new bug referencing the old one.)

From the other bug, which has screenshots:
  - FIrefox : overflow occurs
  - Google Crome : overflow does not occur
  - IE11 : overflow does not occur

Changed in horizon:
status: Fix Committed → Confirmed
assignee: Pablo Fernando Cargnelutti (pablo-fernando-cargnelutti) → nobody
David Lyle (david-lyle)
Changed in horizon:
milestone: juno-rc1 → kilo-1
Changed in horizon:
assignee: nobody → Kelly Domico (kelly-domico)
Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
Kelly Domico (kelly-domico) wrote :

Fix proposed and review available at: https://review.openstack.org/#/c/133763/

Changed in horizon:
assignee: Kelly Domico (kelly-domico) → Lin Hua Cheng (lin-hua-cheng)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/134311
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=64fdf2bfc1a3e329b3058913b7e67f550a0fb6b3
Submitter: Jenkins
Branch: master

commit 64fdf2bfc1a3e329b3058913b7e67f550a0fb6b3
Author: Kelly Domico <email address hidden>
Date: Thu Nov 13 09:30:03 2014 -0800

    Set row action dropdown to right-align

    Added dropdown-menu-right to row action dropdowns so that
    menus with long titles don't extend out of the view.

    Change-Id: Ifafeec3a79e6b8e42381405039d0d0dcf3cd7d71
    Closes-Bug: #1392394
    Closes-Bug: #1300868

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-1 → 2015.1.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Kelly Domico (<email address hidden>) on branch: master
Review: https://review.openstack.org/133763

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.