Cannot know which container is focused

Bug #1299828 reported by Akihiro Motoki
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Richard Jones

Bug Description

In "Containers" panel, we cannot distinguish which container is focused.
Previously focused container has different background color and we can know a focused folder.

Tags: swift
Changed in horizon:
status: New → Triaged
importance: Undecided → Medium
Changed in horizon:
assignee: nobody → Richard Jones (r1chardj0n3s)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/103785

Changed in horizon:
status: Triaged → In Progress
David Lyle (david-lyle)
Changed in horizon:
milestone: none → juno-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/103785
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b170a07b7c17ab0969da4c91c801c88347ce2c0e
Submitter: Jenkins
Branch: master

commit b170a07b7c17ab0969da4c91c801c88347ce2c0e
Author: Richard Jones <email address hidden>
Date: Tue Jul 1 18:02:53 2014 +1000

    Reinstate highlighting of selected container in Containers view

    The AJAX updating of the containers is the culprit here in a couple of ways.

    Firstly, the AJAX update (the short-circuit in MultiTableView.construct_tables)
    doesn't have the context from the URL which indicates which of the rows should
    be highlighted. This is because the current_item_id is only set on the
    navigation table in the case where the whole browser is being rendered, rather
    than just part of it. Shifting setting that attribute to all cases allows
    lower-level access to the attribute.

    Secondly, the handling of the AJAX update (in DataTable.maybe_preempt)
    doesn't check the row it creates to see whether it should be selected.

    Change-Id: Ibecb761a4bde25c1ea4e33a581dd0586ecc42ea0
    Closes-bug: 1299828

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.