DynamicSelectWidget.get_add_item_url excessively wraps args parameter for reverse

Bug #1297317 reported by Timur Sufiev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Timur Sufiev

Bug Description

See https://github.com/openstack/horizon/blob/stable/havana/horizon/forms/fields.py#L41 - self.add_item_link_args is wrapped with additional list, so in case we pass several arguments to resolver inside add_item_link_args attribute, the final url won't be resolved as expected.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/82833

Changed in horizon:
assignee: nobody → Timur Sufiev (tsufiev-x)
status: New → In Progress
Matthias Runge (mrunge)
Changed in horizon:
milestone: none → juno-1
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/82833
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=88c0436fa1f21fceea95f8b4c192419dd9bdeaa1
Submitter: Jenkins
Branch: master

commit 88c0436fa1f21fceea95f8b4c192419dd9bdeaa1
Author: Timur Sufiev <email address hidden>
Date: Tue Mar 25 18:17:55 2014 +0400

    Fix DynamicSelectWidget.get_add_item_url() method.

    Do not wrap self.add_item_link_args in an additional list because it
    makes impossible to pass more than one arg (i.e. tuple or list of
    args) to url resolver.

    Change-Id: Idf6d5d1f27c9176f1de93a475e0f1abbae5ee275
    Closes-Bug: #1297317

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
importance: Undecided → Low
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.