openstack.common needs to be synced and unused module should be removed

Bug #1296337 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Akihiro Motoki

Bug Description

Most modules in openstack_dashboard/openstack/common are out-of-date and need to be synced with latest oslo.
The following modules are out-of-date.

In addition, many modules are not used in OpenStack Dashboard. If I remember correctly, they were introduced because of third-party integration but if it is required in third-party implementation they should import oslo in their tree not in the upstream.
Note that notifier and rpc in oslo now graduated oslo-incubator and maintained as separate module (oslo.messaging).
Use of oslo-incubator rpc and oslo is deprecated.
IMO they should be removed from horizon tree from the maitenance perspective before Icehouse release.

- config/*
- context
- eventlet_backdoor
- loopingcall
- network_utils
- notifier/*
- rpc/*
- service
- threadgroup
- uuidutils

Akihiro Motoki (amotoki)
Changed in horizon:
assignee: nobody → Akihiro Motoki (amotoki)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/82382

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/82383

Changed in horizon:
importance: Undecided → Low
milestone: none → juno-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/82382
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b8b8bff7d137e9cae72e9ec20505a0c4b1f886b6
Submitter: Jenkins
Branch: master

commit b8b8bff7d137e9cae72e9ec20505a0c4b1f886b6
Author: Akihiro Motoki <email address hidden>
Date: Mon Mar 24 02:18:21 2014 +0900

    Remove unused openstack.common modules

    They are not used in horizon code base and out-of-date for a long time.
    It is time to remove them.
    - notifier and rpc graduated oslo-incubator and are distirubted as a
      separate module (oslo.messaging).
    - uuidutils is now deprecated in oslo and standard uuid module is
      recommended to use.
    - For other modules, we can re-add them if they becomes needed.

    Partial-Bug: #1296337
    Change-Id: I7cb569954384fd39e9f91316f5e22ca63f4a00ee

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote :

Reviewed: https://review.openstack.org/82383
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=21b7822f9b73e8ec4ce200493cf819495b677735
Submitter: Jenkins
Branch: master

commit 21b7822f9b73e8ec4ce200493cf819495b677735
Author: Akihiro Motoki <email address hidden>
Date: Mon Mar 24 02:55:20 2014 +0900

    Sync latest Oslo

    Sync from oslo-incubator commit 46f2b697b6aacc674bc040a8751997ed70490d1a

    Major changes of the import are related to update policy module:
    0da5de6b54 Allow policy.json resource vs constant check
    5d1f15a778 Documenting policy.json syntax
    33533b0d97 Keystone user can't perform revoke_token

    Most changes are style-related topics:
    * Improve Python3 compatibility
    * Remove vim modelines
    * Support Per-log-level logging translations

    Closes-Bug: #1296337
    Change-Id: I09f61b10b1b36015d248de25c5c6ed994717a565

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-1 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.