OpenStack Dashboard (Horizon)

horizon_workflow.scss could be more scss-like

Bug #1295847 reported by Matthew D. Wood
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Matthew D. Wood
OpenStack Dashboard (Horizon) 2014.2 "juno"

Bug Description

horizon_workflow.less could be more less and less css. :-)

Really, I wanted to experiment around with less and I believe I have improved the file.

Tags: less
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/82209

Changed in horizon:
assignee: nobody → Matthew D. Wood (woodm1979)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/83214

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Matthew D. Wood (<email address hidden>) on branch: master
Review: https://review.openstack.org/82209
Reason: All less files have been converted to scss files. I'll redo this in a different review.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/104711

Matthew D. Wood (woodm1979)
summary: - horizon_workflow.less could be more less-like
+ horizon_workflow.scss could be more scss-like
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/105195

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Matthew D. Wood (<email address hidden>) on branch: master
Review: https://review.openstack.org/105195
Reason: Somehow this review got copied over.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/104711
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6e6509ae0de933e03056eabb8c6d836d63640edc
Submitter: Jenkins
Branch: master

commit 6e6509ae0de933e03056eabb8c6d836d63640edc
Author: woodm1979 <email address hidden>
Date: Thu Jul 3 16:46:23 2014 -0600

    horizon_workflow.scss could be more scss-like

    horizon_workflow.scss is currently pretty much css. There's some
    semi-sophisticated css in there (the arrows) and it would be improved
    with some variable usage and more nesting.

    Based on my previous less-ify here:
    https://review.openstack.org/#/c/82209/

    NOTE: I've verified that the resulting .css file is exactly the same as
    before.

    NOTE 2: Per Maxime's suggestion, I've moved the variable declarations
    into the _variables.scss file, and changed the format of a few of them.
    The resulting .css file is now slightly different but only because
    "white" is different from "#ffffff"

    Change-Id: Ie31de779285c5f417c9cd7c8edc7ff5e7b527f5e
    Closes-Bug: 1295847

Changed in horizon:
status: In Progress → Fix Committed
Russell Bryant (russellb)
Changed in horizon:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.