testing fails on specific systems due to dictionnary ordering

Bug #1293692 reported by Maxime Vidori
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Maxime Vidori

Bug Description

Due to the use of dictionaries in horizon some tests will differ depending on the platform/system.

A good example is horizon.tables.base.Row#get_ajax_update_url (l564) which will encode a dict in an url but the test use a static string, so the result can diverge.

My config is an ubuntu 12.04 with python 2.6 installed with http://askubuntu.com/questions/125342/how-can-i-install-python-2-6-on-12-04, just install and run tox -epy26 and it will fail.

Changed in horizon:
assignee: nobody → Maxime Vidori (maxime-vidori)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/81289

Changed in horizon:
status: New → In Progress
summary: - urlencode testing fails on specific systems
+ testing fails on specific systems due to dictionnary ordering
Changed in horizon:
assignee: Maxime Vidori (maxime-vidori) → Radomir Dopieralski (thesheep)
Changed in horizon:
assignee: Radomir Dopieralski (thesheep) → Maxime Vidori (maxime-vidori)
Changed in horizon:
assignee: Maxime Vidori (maxime-vidori) → Radomir Dopieralski (thesheep)
Changed in horizon:
assignee: Radomir Dopieralski (thesheep) → Maxime Vidori (maxime-vidori)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/81289
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=099fd156562933de352c5158057d7912be163b0f
Submitter: Jenkins
Branch: master

commit 099fd156562933de352c5158057d7912be163b0f
Author: Maxime Vidori <email address hidden>
Date: Tue Mar 18 16:32:17 2014 +0100

    Fix testing fails on specific platforms

        Due to the use of dictionaries and sets, some tests fails especially in
    the html rendering (attributes are stored in a dictionary), and in
    admin/aggregates, where API calls are checked over a set and the use of
    InAnyOrder function of mox is needed.

    Co-Authored-By: florent <email address hidden>
    Change-Id: I9f8482179b7f3c9175c98115770b5239cbd84cb9
    Closes-Bug: #1293692

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
milestone: none → juno-2
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: juno-2 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.