horizon messages not shown on redirect to logout

[David Lapsley]

When a user is redirected to logout via the success_url of a form/action, any messages generated by the form/action workflow are not shown prior to logout, but instead are shown on the next login.

This is not a problem for any current features, but will become a problem for future features that require a redirect to logout.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/96560

[Julie Pichon (jpichon)]

I don't think this patch should be merged, the messages are not displayed on the login page by design and due to security concerns, see https://bugs.launchpad.net/horizon/+bug/1165702 . The awkward cookie-based way to display messages on the login page ( https://blueprints.launchpad.net/horizon/+spec/messages-on-login-page ) was devised to only allow specific, known trusted messages to be shown. Specific features should try and use the function to add messages on logout at https://github.com/openstack/horizon/blob/master/horizon/utils/functions.py .

[OpenStack Infra (hudson-openstack)]

Change abandoned by Dave Lapsley (<email address hidden>) on branch: master
Review: https://review.openstack.org/96560
Reason: Post-approve was decided that it's better not to merge this. Hopefully this will stop the merge.

[David Lyle (david-lyle)]

don't we already handle this with logout reason?

[Launchpad Janitor (janitor)]

[Expired for OpenStack Dashboard (Horizon) because there has been no activity for 60 days.]