When creating an image, image location does not have the asterisk symbol to show it is a required field

[mariam john]

Follow the link Project -> Image and try to create a new image. There are actually 2 issues here:
1. image location is a required field but it does not have an asterisk symbol to denote its required.
2. try creating an image without specifying the image location. It errors out and goes back to the dashboard console instead of staying on the create image pop up screen.

[Ana Krivokapić (akrivoka)]

Lack of the asterisk symbol is a valid issue and it should be fixed.

I am not sure about the second mentioned issue, though. It errors out but it does not go back to the dashboard, it just displays the form in a normal page instead of in a modal dialog. This error handling approach is used throughout Horizon, and I don't see a need to change it.

[mariam john (mariamj)]

Sorry about my description about the second issue. I didnt explain that well. I have attached 3 screen shots which might help explain what I was expecting to see. In the required_port.png (Projects -> Access & Security -> Edit Rules -> Add Rule), port is a required field and when I dont fill that and still try to create a new rule, it shows me an error message on the same pop up. Back to creating an image scenario, when I try to create an image, it opens up a pop up window for this purpose and I go ahead and enter the image name and image format and click 'Create Image' button. At that point, I was expecting to see if show an error message saying that the image location is a required field on the same pop-up window. Instead it took me back to the main window (after_create_img.png).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/124712

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/124712
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[Susan Tan (susan-tan-fleckerl)]

I assume that this assigned ticket hasn't been worked on since November 24, 2015. I'm assigning this to myself now.

[Susan Tan (susan-tan-fleckerl)]

Please notice that additional fields in this image pop-up modal are also required. The ticket specifically mentions that there should be a blue asterisk on the image url location field. In my commit, I'm gong to add in the blue asterisk to the other required fields such as name and format.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/283210

[Susan Tan (susan-tan-fleckerl)]

The proposed solution creates a blue "*" in front of both the image file and image location name labels.

[OpenStack Infra (hudson-openstack)]

Change abandoned by David Lyle (<email address hidden>) on branch: master
Review: https://review.openstack.org/283210
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[srikanth (k1039485)]

@Susan Tan can i work on this bug

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/369954

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/369954
Reason: Abandoned due to inactivity. Feel free to restore and work on it if you have time

[Beth Elwell (bethelwell)]

This bug relates to the old panel before changes were made that fix this issue in the new layout. Therefore I am closing this bug as invalid as the fix has been made, although not in direct relation to this bug.